Bugfix/ci lint proguard (facebook#19724)

gengjiawen · facebook-github-bot · commit 86d8c7a9b37c · 2018-06-15T08:01:51.000-07:00
Summary: * avoid lint to interrupt ci * add proguard rules pass all ci none [GENERAL] [ENHANCEMENT] [CI] - Fix lint and proguard Closes facebook#19724 Differential Revision: D8446721 Pulled By: hramos fbshipit-source-id: b21c5418210b27dda6a7194995a25df39af0c92a
diff --git a/RNTester/android/app/build.gradle b/RNTester/android/app/build.gradle
@@ -120,6 +120,11 @@ android {
             signingConfig signingConfigs.release
         }
     }
+
+    lintOptions {
+        abortOnError false
+    }
+
     // applicationVariants are e.g. debug, release
     applicationVariants.all { variant ->
         variant.outputs.each { output ->
diff --git a/build.gradle b/build.gradle
@@ -35,4 +35,12 @@ allprojects {
             url "$androidSdk/extras/m2repository/"
         }
     }
+
+    project.configurations.all {
+        resolutionStrategy.eachDependency { details ->
+            if (details.requested.group == 'com.facebook.soloader') {
+                details.useVersion "0.3.0"
+            }
+        }
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,11 @@ android {`
`120`	`120`	`signingConfig signingConfigs.release`
`121`	`121`	`}`
`122`	`122`	`}`
	`123`	`+`
	`124`	`+ lintOptions {`
	`125`	`+ abortOnError false`
	`126`	`+ }`
	`127`	`+`
`123`	`128`	`// applicationVariants are e.g. debug, release`
`124`	`129`	`applicationVariants.all { variant ->`
`125`	`130`	`variant.outputs.each { output ->`
Original file line number	Diff line number	Diff line change
`@@ -35,4 +35,12 @@ allprojects {`
`35`	`35`	`url "$androidSdk/extras/m2repository/"`
`36`	`36`	`}`
`37`	`37`	`}`
	`38`	`+`
	`39`	`+ project.configurations.all {`
	`40`	`+ resolutionStrategy.eachDependency { details ->`
	`41`	`+ if (details.requested.group == 'com.facebook.soloader') {`
	`42`	`+ details.useVersion "0.3.0"`
	`43`	`+ }`
	`44`	`+ }`
	`45`	`+ }`
`38`	`46`	`}`