Skip to content

[Bug] Linkedin icon shows as missing image when exported to pdf #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
sale-silfra opened this issue Dec 28, 2024 · 8 comments · Fixed by #2143
Closed
1 task done

[Bug] Linkedin icon shows as missing image when exported to pdf #2126

sale-silfra opened this issue Dec 28, 2024 · 8 comments · Fixed by #2143
Assignees
Labels
bug Something isn't working needs triage Issues that need to be triaged v4 Issues related to the latest version

Comments

@sale-silfra
Copy link

Is there an existing issue for this?

  • Yes, I have searched the existing issues and none of them match my problem.

Product Variant

Cloud (https://rxresu.me)

Current Behavior

The linkedin icon shows as "missing image" when resume is exported to a pdf file.

Screenshot 2024-12-28 223116

Expected Behavior

It should show the icon in the pdf just like in the web preview

Steps To Reproduce

  1. Create a resume
  2. Add a Linkedin url
  3. Export the resume to a pdf
  4. Observe the missing image icon

What browsers are you seeing the problem on?

Chrome

What template are you using?

Onyx

Anything else?

No response

@sale-silfra sale-silfra added bug Something isn't working needs triage Issues that need to be triaged v4 Issues related to the latest version labels Dec 28, 2024
@sale-silfra
Copy link
Author

It looks like Simple Icons might have removed the LinkedIn icon form their set. I can't find it on their website

@kushagra-xo
Copy link

that's a bummer, is there any workaround as of right now?

@va2ron1
Copy link

va2ron1 commented Dec 29, 2024

I've encountered the same issue and implemented a fix that now supports using full URL images. Check it out here:
https://github.com/va2ron1/Reactive-Resume/tree/feature/icon-fix

@theTaikun
Copy link

Simple Icons did indeed remove LinkedIn, per M$ request:

simple-icons/simple-icons#11372

I like the solution provided by @va2ron1 which seems to allow specifying urls with fall back to Simple Icons, but I haven't tested it yet.

@techtanic
Copy link

What is the solution for this, Can @va2ron1 solution be merged

@manuelmolinaf
Copy link

Heyy, is this being worked on?

@AmruthPillai
Copy link
Owner

Trying to think of other solutions to this. It's an unfortunate situation that Simple Icons was struck down by Microsoft, and choosing any other icon library could lead to the same fate. I am exploring @va2ron1's solution right now, just need to ensure it's a secure solution and also that it doesn't break the layout of the resume (for example, providing an image URL that is extremely large).

@LitoMore
Copy link

LitoMore commented Jan 12, 2025

@AmruthPillai It looks like you already limited the image size with <img> attributes.

I think what is more important is that external resources may have tracking.

As LinkedIn's policy mentioned:

The only use of LinkedIn brand features that is permitted without a separate agreement is that if you are a LinkedIn member, you may use the “in” Logo to designate a link to your personal profile or to a Group or Company page or to promote you or your organization’s presence on LinkedIn.

This is fine for users linking to their profiles.

So that you can consider storing the image asset to your project (under your public directory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Issues that need to be triaged v4 Issues related to the latest version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants