Skip to content

Commit d08eed3

Browse files
committed
zpool: Two small fixes for openzfs#11167
Follow up fix for 0cb40fa. Remove unused variables and add missed cleanup. Signed-off-by: Attila Fülöp <[email protected]>
1 parent d1d4769 commit d08eed3

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

tests/zfs-tests/tests/functional/cli_root/zpool_add/zpool_add_dryrun_output.ksh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
. $STF_SUITE/include/libtest.shlib
2828
. $STF_SUITE/tests/functional/cli_root/zpool_add/zpool_add.kshlib
2929

30-
typeset TMPFILE_PREFIX="$TEST_BASE_DIR/zpool_add_dryrun_output"
3130
typeset STR_DRYRUN="would update '$TESTPOOL' to the following configuration:"
3231
typeset VDEV_PREFIX="$TEST_BASE_DIR/filedev"
3332

@@ -136,7 +135,7 @@ verify_runnable "global"
136135
function cleanup
137136
{
138137
destroy_pool "$TESTPOOL"
139-
rm -f "$TMPFILE_PREFIX"* "$VDEV_PREFIX"*
138+
rm -f "$VDEV_PREFIX"*
140139
}
141140

142141
log_assert "'zpool add -n <pool> <vdev> ...' can display the configuration"

tests/zfs-tests/tests/functional/cli_root/zpool_create/zpool_create_dryrun_output.ksh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
. $STF_SUITE/include/libtest.shlib
2828
. $STF_SUITE/tests/functional/cli_root/zpool_create/zpool_create.shlib
2929

30-
typeset TMPFILE_PREFIX="$TEST_BASE_DIR/zpool_create_dryrun_output"
3130
typeset STR_DRYRUN="would create '$TESTPOOL' with the following layout:"
3231
typeset VDEV_PREFIX="$TEST_BASE_DIR/filedev"
3332

@@ -112,13 +111,12 @@ verify_runnable "global"
112111

113112
function cleanup
114113
{
115-
rm -f "$TMPFILE_PREFIX"* "$VDEV_PREFIX"*
114+
rm -f "$VDEV_PREFIX"*
116115
}
117116

118117
log_assert "'zpool add -n <pool> <vdev> ...' can display the configuration"
119118

120119
log_onexit cleanup
121-
typeset disk1=$(create_blockfile $FILESIZE)
122120

123121
# Create needed file vdevs.
124122
for (( i=0; i < ${#dev[@]}; i+=1 )); do

tests/zfs-tests/tests/functional/cli_root/zpool_split/zpool_split_dryrun_output.ksh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ verify_runnable "global"
118118
function cleanup
119119
{
120120
destroy_pool "$TESTPOOL"
121+
rm -f "$VDEV_PREFIX"*
121122
}
122123

123124
log_assert \

0 commit comments

Comments
 (0)