CRM: Update FullCalendar from v3 to v6 (#43970)

* Fix zeroBSCRM_getLocale

If one ever requested the short version of the locale, it would always return the short version on subsequent calls, even if requesting the full version. We now cache the full version, and derive the short version from that as needed.

* Bump to FullCalendar 5

This also temporarily removes avatar and completion checkmark event UI modifications, since styling has changed significantly between versions and will likely continue to do so as we continue upgrades.

* Bump to FullCalendar 6

* Remove FullCalendar style overrides

* Add styles and task completion

* Add changelog

* Remove peer dependency hack

* Update pnpm-lock.yaml

* Update Phan baseline

* Reduce explicit dependencies

* Update pnpm-lock.yaml

* Prevent error on task edit page

* Fix links on list view

* Adjust header styles for small screens

* More adjustments

* Show user dropdown for all task-perms people

Author: tbradsha

.pnpmfile.cjs

@@ -305,12 +305,6 @@ function fixPeerDeps( pkg ) {
 		}
 	}
 
-	// Remove jQuery peer dependency, given it's already bundled in WordPress.
-	// The next version of FullCalendar (v4) removes the dependency altogether.
-	if ( pkg.name === 'fullcalendar' && pkg.peerDependencies?.jquery ) {
-		delete pkg.peerDependencies.jquery;
-	}
-
 	// It assumes hoisting to find its plugins. Sigh. Add peer deps for the plugins we use.
 	// https://github.com/ai/size-limit/issues/366
 	if ( pkg.name === 'size-limit' ) {

pnpm-lock.yaml

@@ -213,7 +213,7 @@
         'includes/ZeroBSCRM.InvoiceBuilder.php' => ['PhanPluginDuplicateAdjacentStatement', 'PhanPluginDuplicateExpressionAssignmentOperation', 'PhanPluginDuplicateExpressionBinaryOp', 'PhanPluginRedundantAssignment', 'PhanPossiblyUndeclaredVariable', 'PhanTypeExpectedObjectPropAccess', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal', 'PhanTypePossiblyInvalidDimOffset', 'PhanTypeSuspiciousStringExpression', 'PhanUndeclaredTypeReturnType', 'PhanUndeclaredVariable'],
         'includes/ZeroBSCRM.Jetpack.php' => ['PhanPluginDuplicateConditionalNullCoalescing'],
         'includes/ZeroBSCRM.List.Columns.php' => ['PhanPluginMixedKeyNoKey'],
-        'includes/ZeroBSCRM.List.Tasks.php' => ['PhanRedundantCondition', 'PhanTypeMismatchArgument'],
+        'includes/ZeroBSCRM.List.Tasks.php' => ['PhanTypeMismatchArgument'],
         'includes/ZeroBSCRM.List.php' => ['PhanPossiblyUndeclaredVariable', 'PhanRedundantCondition', 'PhanTypeArraySuspicious', 'PhanTypeArraySuspiciousNullable', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentInternal'],
         'includes/ZeroBSCRM.Mail.php' => ['PhanImpossibleCondition', 'PhanPluginMixedKeyNoKey', 'PhanPluginRedundantAssignment', 'PhanPluginUnreachableCode', 'PhanRedundantCondition', 'PhanSuspiciousValueComparison', 'PhanTypeMismatchArgumentInternalReal', 'PhanTypeSuspiciousStringExpression', 'PhanUndeclaredClassCatch', 'PhanUndeclaredClassInstanceof', 'PhanUndeclaredClassMethod', 'PhanUndeclaredClassProperty', 'PhanUndeclaredClassReference', 'PhanUndeclaredVariable', 'PhanUnreferencedUseNormal'],
         'includes/ZeroBSCRM.MailTracking.php' => ['PhanTypeArraySuspiciousNullable'],

projects/plugins/crm/.phan/baseline.php

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Tasks: Update FullCalendar to latest version.

projects/plugins/crm/changelog/update-crm-fullcalendar

@@ -571,23 +571,21 @@ function zeroBSCRM_format_quantity( $quantity ) {
 
 function zeroBSCRM_getLocale( $full = true ) {
 
+	// phpcs:disable WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
 	global $zeroBSCRM_locale;
 
-	if ( isset( $zeroBSCRM_locale ) ) {
-		return $zeroBSCRM_locale;
+	if ( ! isset( $zeroBSCRM_locale ) ) {
+		$zeroBSCRM_locale = get_bloginfo( 'language' );
 	}
 
-	$zeroBSCRM_locale = get_bloginfo( 'language' );
-
 	if ( ! $full ) {
-
-		$zeroBSCRM_locale = str_replace( '_', '-', $zeroBSCRM_locale ); // just in case en_GB?
-		$langParts        = explode( '-', $zeroBSCRM_locale );
-		$zeroBSCRM_locale = $langParts[0];
-
+		$zeroBSCRM_locale_short = str_replace( '_', '-', $zeroBSCRM_locale ); // just in case en_GB?
+		$zeroBSCRM_locale_short = explode( '-', $zeroBSCRM_locale_short )[0];
+		return $zeroBSCRM_locale_short;
 	}
 
 	return $zeroBSCRM_locale;
+	// phpcs:enable WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
 }
 
 // getLocale wrapper