Skip to content

Help Center: more accurate support session detection #103936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Jun 3, 2025

Part of HAL-154
Requires Automattic/jetpack#43752

Proposed Changes

This fix is twofold:

  1. Previously, we tried a couple of ways to prevent the Help Center from re-opening automatically in Support Sessions (Help Center auto-open: Failover to proxied status when all fails #99428, Help Center: don't autoopen the Help Center in Support Sessions #99164), these failed so we put together a fallback, to disabling auto-opening in proxied sessions. This broke the UX for Automatticians. This PR disables the auto-open feature in Support Session only. It should work this time.
  2. It always targets the production instance of Zendesk when the user in SU. This is congruent with wpcom#83114.

Why are these changes being made?

To prevent HEs from landing in Stanging when SUing.

Testing Instructions

HC

  1. Open the live link while proxied.
  2. Open the Help Center.
  3. Refresh the page.
  4. The HC should pop open automatically.

SU

  1. SU into some user while proxied.
  2. Open the HC.
  3. It should access ZD prod.

Copy link

github-actions bot commented Jun 3, 2025

@alshakero alshakero requested a review from a team June 3, 2025 19:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 3, 2025
@alshakero alshakero added [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 3, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 3, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/help-center-is-ss on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~22 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper                +63 B  (+0.0%)      +22 B  (+0.0%)
entry-reauth-required        +63 B  (+0.0%)      +22 B  (+0.0%)
entry-main                   +63 B  (+0.0%)      +22 B  (+0.0%)
entry-login                  +63 B  (+0.0%)      +22 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~90 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
site-purchases                           +85 B  (+0.0%)      +22 B  (+0.0%)
purchases                                +85 B  (+0.0%)      +22 B  (+0.0%)
plans                                    +85 B  (+0.0%)      +23 B  (+0.0%)
jetpack-connect                          +85 B  (+0.0%)      +23 B  (+0.0%)
jetpack-cloud-pricing                    +85 B  (+0.0%)      +23 B  (+0.0%)
jetpack-cloud-features-comparison        +85 B  (+0.0%)      +25 B  (+0.0%)
checkout                                 +85 B  (+0.0%)      +20 B  (+0.0%)
a8c-for-agencies-client                  +85 B  (+0.0%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~41 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-components-jetpack-portal-nav        +85 B  (+0.1%)      +19 B  (+0.1%)
async-load-automattic-help-center-stepper               +85 B  (+0.0%)      +22 B  (+0.0%)
async-load-automattic-help-center                       +85 B  (+0.0%)      +22 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@heavyweight heavyweight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@heavyweight heavyweight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alshakero alshakero merged commit babee8e into trunk Jun 4, 2025
14 of 17 checks passed
@alshakero alshakero deleted the fix/help-center-is-ss branch June 4, 2025 10:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 4, 2025
@escapemanuele escapemanuele changed the title Help Center: more accurate supoprt session detection Help Center: more accurate support session detection Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants