fix: Prevent DXGI from intercepting Alt+Enter and PrintScreen #18970
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
MrJul
requested changes
Jun 3, 2025
| @@ -24,6 +24,14 @@ internal unsafe class DxgiRenderTarget : EglPlatformSurfaceRenderTargetBase | |||
| private IUnknown? _renderTexture; | |||
| private RECT _clientRect; | |||
|
|
|||
| [Flags] | |||
| enum AssociationFlags : ushort | |||
There was a problem hiding this comment.
I was confused by the ushort here before realizing that the current parameters had the wrong types.
Please wait for #18991 to get merged, then remove the ushort.
| @@ -24,6 +24,14 @@ internal unsafe class DxgiRenderTarget : EglPlatformSurfaceRenderTargetBase | |||
| private IUnknown? _renderTexture; | |||
| private RECT _clientRect; | |||
|
|
|||
| [Flags] | |||
| enum AssociationFlags : ushort | |||
There was a problem hiding this comment.
Please define this in DirectXEnums.cs for consistency (the name could be DXGI_MWA).
Also, the second parameter for MakeWindowAssociation() in DirectX.idl could probably now be typed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This fixes an issue with forced key shortcuts caused by DXGI composition. By default, DXGI hooks into the window message queue, intercepts the PrintScreen key or Alt+Enter key sequence, and forces any Avalonia app into fullscreen mode. There is currently no way to disable this feature.
This behavior only occurs for apps using
Win32CompositionMode.LowLatencyDxgiSwapChain. Other composition modes are not affected.https://groups.google.com/g/angleproject/c/Ks8QXP6UVBk
What is the current behavior?
Any Avalonia app using Win32CompositionMode.LowLatencyDxgiSwapChain switches to fullscreen mode when the Alt+Enter key sequence is pressed.
What is the updated/expected behavior with this PR?
The updated behavior entirely disables forced fullscreen via Alt+Enter, as well as the PrintScreen key interception.
How was the solution implemented (if it's not obvious)?
The solution involves setting the appropriate flags using
MakeWindowAssociation.https://learn.microsoft.com/en-us/windows/win32/api/dxgi/nf-dxgi-idxgifactory-makewindowassociation
Breaking changes
None