Skip to content

Commit 16daadc

Browse files
SudoBrendanedisonLcardenas
authored andcommitted
Fix make ci-clean and runlocal-rp (#3806)
* Fix make ci-clean error for running work containers by buildah that prevents prune from working * Fix make runlocal-rp image syntax
1 parent 0c7727b commit 16daadc

File tree

1 file changed

+39
-0
lines changed

1 file changed

+39
-0
lines changed

Makefile

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,45 @@ clean:
180180
client: generate $(GOIMPORTS)
181181
hack/build-client.sh "${AUTOREST_IMAGE}" 2020-04-30 2021-09-01-preview 2022-04-01 2022-09-04 2023-04-01 2023-07-01-preview 2023-09-04 2023-11-22 2024-08-12-preview
182182

183+
.PHONY: ci-rp
184+
ci-rp: fix-macos-vendor
185+
podman $(PODMAN_REMOTE_ARGS) \
186+
build . \
187+
-f Dockerfile.ci-rp \
188+
--ulimit=nofile=4096:4096 \
189+
--build-arg REGISTRY=$(REGISTRY) \
190+
--build-arg ARO_VERSION=$(VERSION) \
191+
--no-cache=$(NO_CACHE) \
192+
-t $(LOCAL_ARO_RP_IMAGE):$(VERSION)
193+
194+
# Tag the portal build image if it exists
195+
@PORTAL_IMAGE_ID=$(shell podman $(PODMAN_REMOTE_ARGS) image ls --filter label=stage=portal-build-cache-layer --noheading --format "{{.Id}}" | tail -n 1); \
196+
if [ -n "$$PORTAL_IMAGE_ID" ]; then \
197+
echo "Tagging Portal Image $$PORTAL_IMAGE_ID as $(LOCAL_ARO_PORTAL_BUILD_IMAGE):$(VERSION)"; \
198+
podman $(PODMAN_REMOTE_ARGS) tag $$PORTAL_IMAGE_ID $(LOCAL_ARO_PORTAL_BUILD_IMAGE):$(VERSION); \
199+
else \
200+
echo "No Portal Image found with label stage=portal-build-cache-layer"; \
201+
fi
202+
203+
# Tag the RP build image if it exists
204+
@RP_IMAGE_ID=$(shell podman $(PODMAN_REMOTE_ARGS) image ls --filter label=stage=rp-build-cache-layer --noheading --format "{{.Id}}" | tail -n 1); \
205+
if [ -n "$$RP_IMAGE_ID" ]; then \
206+
echo "Tagging RP Image $$RP_IMAGE_ID as $(LOCAL_ARO_RP_BUILD_IMAGE):$(VERSION)"; \
207+
podman $(PODMAN_REMOTE_ARGS) tag $$RP_IMAGE_ID $(LOCAL_ARO_RP_BUILD_IMAGE):$(VERSION); \
208+
else \
209+
echo "No RP Image found with label stage=rp-build-cache-layer"; \
210+
fi
211+
212+
213+
.PHONY: ci-tunnel
214+
ci-tunnel: fix-macos-vendor
215+
podman build . -f Dockerfile.ci-tunnel --ulimit=nofile=4096:4096 --build-arg REGISTRY=$(REGISTRY) --build-arg ARO_VERSION=$(VERSION) --no-cache=$(NO_CACHE) -t aro-tunnel:$(VERSION)
216+
217+
.PHONY: ci-clean
218+
ci-clean:
219+
$(shell podman ps --external --format "{{.Command}} {{.ID}}" | grep buildah | cut -d " " -f 2 | xargs podman rm -f > /dev/null)
220+
podman image prune --all --filter="label=aro-*=true"
221+
183222
# TODO: hard coding dev-config.yaml is clunky; it is also probably convenient to
184223
# override COMMIT.
185224
.PHONY: deploy

0 commit comments

Comments
 (0)