Skip to content

ignore: publicize ignore::dir #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
noahbkim opened this issue Mar 7, 2025 · 1 comment
Open

ignore: publicize ignore::dir #3014

noahbkim opened this issue Mar 7, 2025 · 1 comment

Comments

@noahbkim
Copy link

noahbkim commented Mar 7, 2025

I was wondering if any of the maintainers had a philosophical objection to making ignore::dir::Ignore and related machinery part of the public API. I've found myself needing to reimplement Walk with slightly modified file system abstractions, and it would be really helpful to be able to reuse the Ignore bits.

Happy to put up the PR if this seems reasonable.
@BayLee4
Copy link

BayLee4 commented Mar 20, 2025 •
edited
Loading

This would be very useful especially with the ability to clone WalkBuilder.ig_builder, that would allow to check if a currently non-existing file/directory would be ignored before creating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noahbkim @BayLee4