Skip to content

Commit 7f9d898

Browse files
authored
Merge pull request #108 from Enmk/fix_LowCardinality_tests
Fixed test if server sends X instead of LowCardinality(X)
2 parents c6c79ab + bfb42f1 commit 7f9d898

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

ut/performance_tests.cpp

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,21 @@ TYPED_TEST_P(ColumnPerformanceTest, InsertAndSelect) {
221221
EXPECT_EQ(1u, block.GetColumnCount());
222222
const auto col = block[0]->As<ColumnType>();
223223

224-
EXPECT_NO_FATAL_FAILURE(ValidateColumnItems(*col, ITEMS_COUNT));
224+
if (col.get() == 0)
225+
{
226+
// If server doesn't send response back as LowCardinality(X) but rather like X.
227+
if constexpr (std::is_base_of_v<ColumnLowCardinality, ColumnType>)
228+
{
229+
using NestedColumnType = typename ColumnType::WrappedColumnType;
230+
EXPECT_NO_FATAL_FAILURE(ValidateColumnItems(*block[0]->As<NestedColumnType>(), ITEMS_COUNT));
231+
}
232+
else
233+
FAIL();
234+
}
235+
else
236+
{
237+
EXPECT_NO_FATAL_FAILURE(ValidateColumnItems(*col, ITEMS_COUNT));
238+
}
225239
inner_loop_duration += timer.Elapsed();
226240
});
227241

0 commit comments

Comments
 (0)