AppendAsColumn doesn't work with Array of Decimals #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

astiunov opened this issue Nov 3, 2019 · 1 comment

astiunov commented Nov 3, 2019

There is a minimal example: https://pastebin.com/RJmKpZ33, which works if you replace ColumnDecimal with ColumnDate or ColumnInt64 for a example.

The second assert fails, because AppendAsColumn calls this method. ColumnDecimal isn't inherited from ColumnVector, so the check there fails.

Contributor

Enmk commented Mar 10, 2022

Fixed in #161, see Unit test here:
https://github.com/ClickHouse/clickhouse-cpp/blob/master/ut/columns_ut.cpp#L956

Enmk closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment