Fix bug when change user name (go-gitea#25637) (go-gitea#25645)

Backport go-gitea#25637 by @lunny

Fix go-gitea#25621

Co-authored-by: Lunny Xiao <[email protected]>
(cherry picked from commit 37bf5e7)

Author: 2 people

models/user/redirect.go

@@ -64,6 +64,10 @@ func NewUserRedirect(ctx context.Context, ID int64, oldUserName, newUserName str
 	oldUserName = strings.ToLower(oldUserName)
 	newUserName = strings.ToLower(newUserName)
 
+	if err := DeleteUserRedirect(ctx, oldUserName); err != nil {
+		return err
+	}
+
 	if err := DeleteUserRedirect(ctx, newUserName); err != nil {
 		return err
 	}