Skip to content

Update version of Uno being used. #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrlacey opened this issue Jun 28, 2022 · 4 comments
Closed

Update version of Uno being used. #174

mrlacey opened this issue Jun 28, 2022 · 4 comments
Assignees
Labels
Uno Issues related to Uno Platform

Comments

@mrlacey
Copy link
Contributor

mrlacey commented Jun 28, 2022

Labs projects are currently targetting Uno 4.2, but 4.3 is out (and 4.4 is due soon)

Uno.UI (v4.2.6) includes a bug that is blocking CommunityToolkit/Tooling-Windows-Submodule#64
However, updating to v 4.3.8 (the latest stable version) causes XamlNamedPropertyRelayGenerator to fail / fall silently--presumably due to the change in the way that Uno uses SourceGenerators.

Also worth confirming/investigating is that as Uno now uses the same sort of Source Generators (SGs) as Labs, does this have any issues for deterministic order? i.e. The Labs SGs rely on the output of the Uno SGs. Can they always be guaranteed to run in the desired order?

Adding a strategy & process for how and when to update to newly released Uno versions should also be planned. Such a plan would naturally extend to all dependencies too.

@michael-hawker
Copy link
Member

Uno just released 4.4 the other day as well.

@michael-hawker
Copy link
Member

Ran into this with the behavior:

"D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Skia.Gtk\CommunityToolkit.Labs.Skia.Gtk.csproj" (default target) (9:6) ->
(CoreCompile target) -> 
  D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Behaviors\NavigateToUriAction.cs(9,29): error CA1001: Type 'NavigateToUriAction' owns disposable field(s) '__storeBackingField' but is not disposable [D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Skia.Gtk\CommunityToolkit.Labs.Skia.Gtk.csproj]
"D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Skia.WPF\CommunityToolkit.Labs.Skia.WPF.csproj" (default target) (10:7) ->
  D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Behaviors\NavigateToUriAction.cs(9,29): error CA1001: Type 'NavigateToUriAction' owns disposable field(s) '__storeBackingField' but is not disposable [D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Skia.WPF\CommunityToolkit.Labs.Skia.WPF.csproj]
"D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Wasm\CommunityToolkit.Labs.Wasm.csproj" (default target) (13:6) ->
  D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Behaviors\NavigateToUriAction.cs(9,29): error CA1001: Type 'NavigateToUriAction' owns disposable field(s) '__storeBackingField' but is not disposable [D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Wasm\CommunityToolkit.Labs.Wasm.csproj]

So need to check if still an issue on latest Uno or file an issue.

@Arlodotexe
Copy link
Member

Arlodotexe commented Jul 27, 2022

Looks like only the WPF is having issues when upgrading Uno.

I've tried to update our WPF head to the latest version of the Uno templates, but ran into this issue

@Arlodotexe
Copy link
Member

Closed in #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Uno Issues related to Uno Platform
Projects
None yet
Development

No branches or pull requests

3 participants