Remove Custom Caching Strategy from ImageEx

Too Large an Impact on App Binary Size 675kb

Author: michael-hawker

Microsoft.Toolkit.Uwp.UI.Controls.Core/ImageEx/CachingStrategy.cs

@@ -40,11 +40,6 @@ public partial class ImageExBase
         /// </summary>
         public static readonly DependencyProperty IsCacheEnabledProperty = DependencyProperty.Register(nameof(IsCacheEnabled), typeof(bool), typeof(ImageExBase), new PropertyMetadata(false));
 
-        /// <summary>
-        /// Identifies the <see cref="CachingStrategy"/> dependency property.
-        /// </summary>
-        public static readonly DependencyProperty CachingStrategyProperty = DependencyProperty.Register(nameof(CachingStrategy), typeof(ImageExCachingStrategy), typeof(ImageExBase), new PropertyMetadata(ImageExCachingStrategy.Custom));
-
         /// <summary>
         /// Identifies the <see cref="EnableLazyLoading"/> dependency property.
         /// </summary>
@@ -126,15 +121,6 @@ public bool IsCacheEnabled
             set { SetValue(IsCacheEnabledProperty, value); }
         }
 
-        /// <summary>
-        /// Gets or sets a value indicating how the <see cref="ImageEx"/> will be cached.
-        /// </summary>
-        public ImageExCachingStrategy CachingStrategy
-        {
-            get { return (ImageExCachingStrategy)GetValue(CachingStrategyProperty); }
-            set { SetValue(CachingStrategyProperty, value); }
-        }
-
         /// <summary>
         /// Gets or sets a value indicating whether gets or sets is lazy loading enable. (17763 or higher supported)
         /// </summary>

Microsoft.Toolkit.Uwp.UI.Controls.Core/ImageEx/ImageExBase.Members.cs

@@ -138,17 +138,7 @@ private async Task LoadImageAsync(Uri imageUri)
             {
                 if (IsCacheEnabled)
                 {
-                    switch (CachingStrategy)
-                    {
-                        case ImageExCachingStrategy.Custom when _isHttpSource:
-                            await SetHttpSourceCustomCached(imageUri);
-                            break;
-                        case ImageExCachingStrategy.Custom:
-                        case ImageExCachingStrategy.Internal:
-                        default:
-                            AttachSource(new BitmapImage(imageUri));
-                            break;
-                    }
+                    AttachSource(new BitmapImage(imageUri));
                 }
                 else if (string.Equals(_uri.Scheme, "data", StringComparison.OrdinalIgnoreCase))
                 {