Skip to content

Several markdown tests are failing #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nmetulev opened this issue Aug 12, 2017 · 8 comments
Closed

Several markdown tests are failing #1383

nmetulev opened this issue Aug 12, 2017 · 8 comments
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior bugbash 🏗️ help wanted Issues identified as good community contribution opportunities
Milestone
6.1

Comments

@nmetulev
Copy link
Contributor

After consolidating Unit Test projects (re #1377), several tests are now failing (I don't believe the tests were actually running before).
@nmetulev nmetulev added the help wanted Issues identified as good community contribution opportunities label Aug 12, 2017
@Code-ScottLe
Copy link
Contributor

Code-ScottLe commented Aug 14, 2017 •
edited
Loading

Do we need the tests to be fixed or is this problem with markdown control? And do you have a list of tests that failing? (if this has to be branched off from dev instead of targetupdate)

@nmetulev
Copy link
Contributor Author

I believe the tests are failing because there are bugs or features missing that were never added.

This are the ones failing right now:
image

@Code-ScottLe
Copy link
Contributor

I will take a look. But ping @QuinnDamerell to see if he has any additional context.

@avknaidu
Copy link
Member

@nmetulev I know there are few other PR's about Tests. Are there still issues with these tests? Or we can close this?

@nmetulev
Copy link
Contributor Author

We still have several tests failing, most around the MarkdownTextBlock. @avknaidu, feel free to take a look at those, would help out a lot :)

@avknaidu avknaidu mentioned this issue May 16, 2018
Merged
4 tasks
@lucaasrojas
Copy link
Contributor

Hey! What's the current status of this issue?

@Kyaa-dost Kyaa-dost added the no-recent-activity 📉 Open Issues that require attention label Oct 2, 2019
@michael-hawker michael-hawker mentioned this issue Feb 11, 2020
Closed
@michael-hawker michael-hawker added bug 🐛 An unexpected issue that highlights incorrect behavior bugbash 🏗️ and removed no-recent-activity 📉 Open Issues that require attention labels Feb 11, 2020
@michael-hawker michael-hawker added this to the 6.1 milestone Feb 11, 2020
@michael-hawker
Copy link
Member

We should make sure to fix he Markdown UnitTests so that we can have a successful UnitTest pass available to later integrate into our CI.

It'd be great to not just comment these out, but make sure they're fixed and running as the Markdown control seems widely used and is rather complex.

@michael-hawker michael-hawker mentioned this issue Feb 11, 2020
Closed
3 tasks
@michael-hawker
Copy link
Member

This was resolved by #3207 and for ones we ignored see #3200.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior bugbash 🏗️ help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
6.1
Development

No branches or pull requests
6 participants
@nmetulev @avknaidu @Code-ScottLe @michael-hawker @lucaasrojas @Kyaa-dost