Skip to content

New UI Control for Tags with close button #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilinkmobility opened this issue Nov 20, 2017 · 12 comments
Closed

New UI Control for Tags with close button #1638

ilinkmobility opened this issue Nov 20, 2017 · 12 comments

Comments

@ilinkmobility
Copy link

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[x] Feature request <!-- Please file a UserVoice request and include the link below https://wpdev.uservoice.com/forums/110705-universal-windows-platform/category/193402-uwp-community-toolkit -->
[ ] Sample app request
[ ] Documentation issue or request
[ ] Question of Support request => Please do not submit support request here, instead see https://github.com/Microsoft/UWPCommunityToolkit/blob/master/contributing.md#question

UserVoice link

https://wpdev.uservoice.com/forums/110705-universal-windows-platform/suggestions/32318413-new-ui-control-to-add-tags-with-close-button

Current behavior

Not available

Expected behavior

Control similar add tags in StackOverflow or in Xamarin Forum to add multiple tags with auto suggestion and close button with events.

tags-control2

tags-control

Minimal reproduction of the problem with instructions

Environment

Nuget Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Anniversary Update (14393) 
- [ ] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [ ] Insider Build (xxxxx)

App min and target version:
- [ ] Anniversary Update (14393) 
- [ ] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ ] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 15.3
- [ ] 2017 15.4

@skendrot
Copy link
Contributor

skendrot commented Nov 20, 2017

Seems like this could easily be accomplished with a WrapPanel with a template containing a textblock and button. The sample app pretty much is this, but with remove as the button instead of the x button

@nmetulev
Copy link
Contributor

Agree, doesn't seem like a control would provide much more than what @skendrot has suggested

@Odonno
Copy link
Contributor

Odonno commented Nov 20, 2017

@skendrot @nmetulev And what about the Autocomplete feature at the end of the control?

@skendrot
Copy link
Contributor

Put an AutoSuggestBox as the last item

@avknaidu
Copy link
Member

Something like this?

export

@deanchalk
Copy link

Any of the controls in the Community Toolkit can be recreated by just plonking XAML in a page and wiring up the code-behind. The idea of a control is to make it reusable and easy to use. Many chips control include properties to control the maximum and other features.

@skendrot
Copy link
Contributor

Yes, but we also need to factor in how often a control will be used. If someone is creating a blogging app, sure it's needed. What other apps can benefit from this feature?
I know there is a good use case for a control. Unfortunately that doesn't mean it has a good use case for being in a toolkit.

@deanchalk
Copy link

ok @skendrot if I create one can I put a link to the repo here? so that anyone else that comes here wont ultimately be disappointed ?

@skendrot
Copy link
Contributor

Of course!

@deanchalk
Copy link

deanchalk commented Jan 12, 2018

A bit 'rough and ready', but a reasonable start
https://github.com/deanchalk/UWPChipsControl

https://www.nuget.org/packages/DeanChalk.UWP.ChipsControl/

@gbarcho
Copy link
Contributor

gbarcho commented Jun 28, 2018

Whats the status? @deanchalk are you planning to send a PR?

@kbrons
Copy link
Contributor

kbrons commented Aug 13, 2018

Closing the issue due to inactivity and availability of the control outside the toolkit.

@kbrons kbrons closed this as completed Aug 13, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants