Skip to content

Unit Tests does not run with latest Master #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avknaidu opened this issue May 21, 2018 · 6 comments · Fixed by #3207
Closed

Unit Tests does not run with latest Master #2133

avknaidu opened this issue May 21, 2018 · 6 comments · Fixed by #3207

Comments

@avknaidu
Copy link
Member

I'm submitting a...

Bug report (I searched for similar issues and did not find one)

Current behavior

None of the Unit Tests Except UnitTests.Notifications.NetCore runs with latest master.

Expected behavior

Unit Tests should run

Minimal reproduction of the problem with instructions

Pull or clone Latest Master and "Run All" unit Tests from "Test Explorer"

[22-May-18 2:37:12 AM Error] System.ArgumentException: The parameter is incorrect. (Exception from HRESULT: 0x80070057 (E_INVALIDARG))
   at EnvDTE.Properties.Item(Object index)
   at Microsoft.VisualStudio.TestWindow.VsAdapters.DeviceSelectionHelper.GetSelectedTargetDeviceType(IVsHierarchy vsHierarchy, Boolean isManagedProject)
   at Microsoft.VisualStudio.TestWindow.VsAdapters.VsTestContainer.InitializeTestContainer()
[22-May-18 2:37:12 AM Informational] ------ Run test started ------
[22-May-18 2:38:25 AM Error] Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Failed to initialize client proxy: could not connect to test process.
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyExecutionManager.StartTestRun(TestRunCriteria testRunCriteria, ITestRunEventsHandler eventHandler)
[22-May-18 2:38:25 AM Error] Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Failed to initialize client proxy: could not connect to test process.
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyExecutionManager.StartTestRun(TestRunCriteria testRunCriteria, ITestRunEventsHandler eventHandler)
[22-May-18 2:38:25 AM Informational] ========== Run test finished: 0 run (0:01:13.0770135) ==========

image

Environment

Nuget Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [x] April 2018 Update (17134)
- [ ] Insider Build (build number: )

App min and target version:
- [x] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ ] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [X] 2017 (version: 15.7.1)
- [ ] 2017 Preview (version: )

@nmetulev nmetulev added this to the 3.1 milestone May 25, 2018
@nmetulev nmetulev added help wanted Issues identified as good community contribution opportunities testing 🏗️ labels May 25, 2018
@nmetulev nmetulev modified the milestones: 3.1, 4.0 Jul 11, 2018
@Kyaa-dost Kyaa-dost added the no-recent-activity 📉 Open Issues that require attention label Oct 2, 2019
@michael-hawker michael-hawker added this to the 6.1 milestone Mar 18, 2020
@michael-hawker michael-hawker self-assigned this Mar 18, 2020
@michael-hawker michael-hawker removed help wanted Issues identified as good community contribution opportunities no-recent-activity 📉 Open Issues that require attention labels Mar 26, 2020
@michael-hawker
Copy link
Member

Started working on this on my dev stream, about 1/3ish the way through, but have at least already fixed a bug in the Markdown Parser, though thinking about #3200.

See branch progress here: https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/testsCI%2BUnitTestFixes

@michael-hawker
Copy link
Member

Note: We don't currently have any markdown tests for YAML.

@azchohfi
Copy link
Contributor

This is great. Once we fix the failing tests, we can actually merge #3165 to master, which will be awesome!

@azchohfi
Copy link
Contributor

These are the tests that are still failing: https://dev.azure.com/dotnet/WindowsCommunityToolkit/_build/results?buildId=30739&view=ms.vss-test-web.build-test-results-tab
With your commits it will go down a little bit, but the markdown ones are still not fixed.

@michael-hawker
Copy link
Member

@azchohfi yup, I didn't get to them all yet, but will dig into them more soon. I also branched off your branch from #3165 so I can open a PR and see them build in the CI too.

When I have them all resolved, would you prefer to merge #3165 first and then the PR from this work OR just close #3165 once I open the PR for this one and merge it all together?

@azchohfi
Copy link
Contributor

Let's fix the issues on master, then my tests PR will actually build on the build server hehehe
Make the PR to master.

@ghost ghost added the In-PR 🚀 label Apr 1, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Apr 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants