-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Unit Tests does not run with latest Master #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Started working on this on my dev stream, about 1/3ish the way through, but have at least already fixed a bug in the Markdown Parser, though thinking about #3200. See branch progress here: https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/testsCI%2BUnitTestFixes |
Note: We don't currently have any markdown tests for YAML. |
This is great. Once we fix the failing tests, we can actually merge #3165 to master, which will be awesome! |
These are the tests that are still failing: https://dev.azure.com/dotnet/WindowsCommunityToolkit/_build/results?buildId=30739&view=ms.vss-test-web.build-test-results-tab |
@azchohfi yup, I didn't get to them all yet, but will dig into them more soon. I also branched off your branch from #3165 so I can open a PR and see them build in the CI too. When I have them all resolved, would you prefer to merge #3165 first and then the PR from this work OR just close #3165 once I open the PR for this one and merge it all together? |
Let's fix the issues on master, then my tests PR will actually build on the build server hehehe |
I'm submitting a...
Bug report (I searched for similar issues and did not find one)
Current behavior
None of the Unit Tests Except
UnitTests.Notifications.NetCore
runs with latest master.Expected behavior
Unit Tests should run
Minimal reproduction of the problem with instructions
Pull or clone Latest Master and "Run All" unit Tests from "Test Explorer"
Environment
The text was updated successfully, but these errors were encountered: