Skip to content

Lower the version of the Newtonsoft.Json dependency #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimm98y opened this issue Jun 27, 2019 · 3 comments
Closed

Lower the version of the Newtonsoft.Json dependency #2957

jimm98y opened this issue Jun 27, 2019 · 3 comments

Comments

@jimm98y
Copy link

jimm98y commented Jun 27, 2019

Would it be possible to at least lower the version of the Newtonsoft.Json dependency to 8.0.3? We are using Unity 2017.4 LTS in the project because of the NET scripting backend and HoloLens support and currently all our Unity stuff breaks because this NuGet bumps the Newtonsoft.Json to 10.x and the UnityEngine does not support it apparently - there is a TypeLoadException coming from UnityEngine.Internal.

I know this could be solved in WPF where it is possible to have multiple versions of the same assembly loaded at the same time in different app domains and reference the correct version using an alias, but as far as I know there is no way to do it in UWP.

Originally posted by @jimm98y in #889 (comment)

@ghost ghost added the needs triage 🔍 label Jun 27, 2019
@jimm98y jimm98y changed the title Lower the version of the Newtonsoft dependency Lower the version of the Newtonsoft.Json dependency Jun 27, 2019
@michael-hawker
Copy link
Member

Thanks for the info @jimm98y. I'm not sure if downgrading a dependency would have any other impact in other areas/scenarios (@azchohfi any thoughts?) and if there's anything we're using from newer versions or not. We'll take a look.

@azchohfi
Copy link
Contributor

I think it's a matter of testing and seeing what breaks, and if forcing to upgrade to a newer Newtonsoft.Json does not break the current code we use from it. There is some investigation that needs to be done for this.

@michael-hawker
Copy link
Member

We've removed JSON.NET now for 7.0, so closing this issue.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants