Skip to content

Some classes do not work well on Xaml Islands. #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 17 tasks
azchohfi opened this issue Mar 31, 2020 · 1 comment
Closed
4 of 17 tasks

Some classes do not work well on Xaml Islands. #3205

azchohfi opened this issue Mar 31, 2020 · 1 comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 improvements ✨ introduce breaking changes 💥
Milestone

Comments

@azchohfi
Copy link
Contributor

Describe the bug

Related to CommunityToolkit/Microsoft.Toolkit.Win32#228

There are a lot of issues when some controls and helpers of the toolkit run in the context of a Xaml Island. We need these fixed.

Steps to Reproduce

For example, try to use the ThemeListener class in a WPF app with Islands. It will throw exceptions.
Anything that leverages the Dispatcher using, for example CoreApplication.MainView.Dispatcher, will not work inside Xaml Islands since there is no such thing as a MainView. We need to refactor those to use the new DispatcherQueue.

Expected behavior

Should work in UWP and inside Xaml Islands (.Net Core).

Environment

NuGet Package(s): 6.0.0

Windows 10 Build Number:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • Insider Build (build number: )

App min and target version:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • Insider Build (xxxxx)

Device form factor:

  • Desktop
  • Xbox
  • Surface Hub
  • IoT

Visual Studio

  • 2017 (version: )
  • 2019 (version: )
  • 2019 Preview (version: )
@azchohfi azchohfi added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 31, 2020
@ghost ghost added the needs triage 🔍 label Mar 31, 2020
@ghost
Copy link

ghost commented Mar 31, 2020

Hello azchohfi, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@azchohfi azchohfi mentioned this issue Mar 31, 2020
7 tasks
@ghost ghost added the In-PR 🚀 label Mar 31, 2020
This was referenced Apr 2, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Apr 10, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Apr 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 improvements ✨ introduce breaking changes 💥
Projects
None yet
Development

No branches or pull requests

2 participants