-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Switch to non-EOL .NET Core SDKs in the CI #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The notifications package still targets 3.0. We should move it to 3.1. This is what installs the last SDK that supported 3.0: A PR here would be very simple, and if it passes, it should be quite strait forward to merge it. @michael-hawker I don't think we have any scenario that would require us to support 3.0 or older, right? It is not supported anymore, so we should not support it either. |
I'll send a PR. |
Yeah, especially as EOL, we should move forward, I'm not aware of any reasons for us to need to support specific versions of .NET Core as we only target .NET Standard for the library. It's really all about pipeline/build/CI to build the thing vs. end-developer dependencies. I guess we just missed this one in the last update, wish we could centralize these versions across projects/cake.... Thanks Alex! |
Summary
The CI is currently showing this warning:
Assigning @azchohfi just as a ping, as you're the CI guru 😄
Steps to Reproduce
Steps to reproduce the behavior:
Screenshots
The text was updated successfully, but these errors were encountered: