Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

[Feature] Ensure all controls have style names #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michael-hawker opened this issue Dec 4, 2020 · 1 comment
Closed

[Feature] Ensure all controls have style names #3602

michael-hawker opened this issue Dec 4, 2020 · 1 comment
Labels
feature request 📬 A request for new changes to improve functionality good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software improvements ✨

Comments

@michael-hawker
Copy link
Member

Follow-on from microsoft/microsoft-ui-xaml#3735

Describe the problem this feature would solve

Over time in the toolkit we've been better at adopting better practices around making our styles. We should ensure that we go back and retroactively apply these to other older controls. 7.0 would be a good time to do this...

Describe the solution

Update Styles of controls to ensure that the base style is named and available. (though we may have another issue where these aren't getting exposed to the application level, see: #3556 (comment))

We also generally split out the ControlTemplate as well:

<Style TargetType="ControlName" BasedOn="DefaultControlNameStyle"/>

<Style x:Key="DefaultControlNameStyle" TargetType="ControlName">
    ...
    <Setter Property="Template" Value="{StaticResource DefaultControlTemplate}" />
</Style>

<ControlTemplate x:Key="DefaultControlTemplate" ...
@michael-hawker michael-hawker added improvements ✨ feature request 📬 A request for new changes to improve functionality good first issue Issues identified as good for first-time contributors labels Dec 4, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Dec 4, 2020
@michael-hawker
Copy link
Member Author

Realizing that our DefaultColorPickerStyle is going to conflict with the System/WinUI one... we may want to rename it? DefaultToolkitColorPickerStyle?

@michael-hawker michael-hawker modified the milestones: 7.0, 7.1 Mar 1, 2021
@michael-hawker michael-hawker modified the milestones: 7.1, 7.2/8.0? Aug 31, 2021
@ghost ghost removed this from the 7.2/8.0? milestone Aug 31, 2021
@michael-hawker michael-hawker added the Hacktoberfest Hacktoberfest is a month-long celebration of open source software label Oct 7, 2021
@CommunityToolkit CommunityToolkit locked and limited conversation to collaborators Jul 29, 2022
@LalithaNadimpalli LalithaNadimpalli converted this issue into discussion #4684 Jul 29, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature request 📬 A request for new changes to improve functionality good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software improvements ✨
Projects
None yet
Development

No branches or pull requests

1 participant