Skip to content

ListDetailsView: Won't focus list even if ViewState is not ListDetailsViewState.Details #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
21 tasks
Rosuavio opened this issue Sep 13, 2021 · 0 comments · Fixed by #4255
Closed
21 tasks
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥
Milestone

Comments

@Rosuavio
Copy link
Contributor

Describe the bug

Because of this code the list is not found when we try to focus it.

private void FocusItemList()
{
if (GetTemplateChild("PartMainList") is Control list)
{
list.Focus(FocusState.Programmatic);
}
}

We try to focus the list here, if the ViewState is not ListDetailsViewState.Details

/// <summary>
/// Sets focus to the relevant control based on the viewState.
/// </summary>
/// <param name="viewState">the view state</param>
private void SetFocus(ListDetailsViewState viewState)
{
if (viewState != ListDetailsViewState.Details)
{
FocusItemList();
}
else
{
FocusFirstFocusableElementInDetails();
}
}

The only call site for SetFocus is this

So we only ever use the ViewState prop.

TODO: elaborate the cases when the ViewState is not Details

A clear and concise description of what the bug is.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

  1. Given the following environment (Sample App w/ XAML, Project with Isolated setup, etc...)
  2. Go to '...'
  3. Click on '....'
  4. Scroll down to '....'
  5. See error

Expected behavior

Screenshots

Environment

NuGet Package(s):

Package Version(s):

Windows 10 Build Number:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • May 2020 Update (19041)
  • Insider Build ({build_number})

App min and target version:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • May 2020 Update (19041)
  • Insider Build ({build_number})

Device form factor:

  • Desktop
  • Xbox
  • Surface Hub
  • IoT

Visual Studio version:

  • 2017 (15.{minor_version})
  • 2019 (16.{minor_version})
  • 2022 (17.{minor_version})

Additional context

@Rosuavio Rosuavio added the bug 🐛 An unexpected issue that highlights incorrect behavior label Sep 13, 2021
@Rosuavio Rosuavio added this to the 7.1 milestone Sep 13, 2021
@Rosuavio Rosuavio changed the title ListDetailsView: Won't focus list even if ViewState is not ListDetailsViewState.Details ListDetailsView: Won't focus list even if ViewState is not ListDetailsViewState.Details Sep 13, 2021
@ghost ghost added the In-PR 🚀 label Sep 16, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Sep 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant