[MVVM Toolkit] Possibility to implement or override generated methods in child classes

[hansmbakker]

Currently it is possible to implement logic triggered by ObservableProperty members using generated methods like

partial void OnMyPropertyChanging(...);
partial void OnMyPropertyChanged(...);

However, those methods can only be implemented in the same class where the MyProperty [ObservableProperty] is defined because they are not marked virtual.

This prevents the following usecase:

internal partial class TestVmBase : ObservableObject
{
    [ObservableProperty]
    private bool? myProperty;

    [ObservableProperty]
    private bool? myOtherProperty;
}

internal partial class TestVmChild : TestVmBase
{
    [ObservableProperty]
    private bool isModified;

    private void SetModified() => this.IsModified = true;

    partial void OnMyPropertyChanged(bool? value) => this.SetModified();

    partial void OnMyOtherPropertyChanged(bool? value) => this.SetModified();
}

@Sergio0694 would it be possible to have such functionality in the MVVM Toolkit?

[hansmbakker]

Note: I see for this specific case I could do something like below, but that requires filtering by property name and does not allow me to directly use those generated methods.

internal partial class TestVmBase : ObservableObject
{
    [ObservableProperty]
    private bool? myProperty;
}

internal partial class TestVmChild : TestVmBase
{
    [ObservableProperty]
    private bool isModified;

    protected override void OnPropertyChanged(PropertyChangedEventArgs e)
    {
        base.OnPropertyChanged(e);

        if (e.PropertyName != nameof(this.IsModified))
        {
            this.IsModified = true;
        }
    }
}