Skip to content

Loving it, but the simplicity comes at a cost #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HaydenReeve opened this issue Mar 29, 2024 · 1 comment
Open

Loving it, but the simplicity comes at a cost #2

HaydenReeve opened this issue Mar 29, 2024 · 1 comment

Comments

@HaydenReeve
Copy link

Hello, 👋

Loving your work and glad to have you around.

I've noticed a small issue with the simplicity of this implementation though—you lose some control over small artefacts like character height.

By specifying exact masks you can be more rigorous with "I want this character to fill this area," but with a simple divide at positon x or y you generally end with an output where character heights or differences in posture are genericised. Not something you can really prompt around depending on the checkpoint.

Perhaps a way to allow for 'advanced overrides' might solve this issue. Or an 'advanced version' of the node in parallel which would give you the best of both worlds.

Either way, this is not a mission-critical, this is just an observation of the implementation's side effects. It's still a great node and your hard work is appreciated!

@Danand
Copy link
Owner

Danand commented Apr 6, 2024

@HaydenReeve
Hi! Glad you liked it!

I guess, the same issue is presented in the original node. Oh, I noticed it has been moved to archive recently, btw. So sad.

Maybe another approaches like sketching with ControlNet could do a trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants