Skip to content

Commit 34d2891

Browse files
api-clients-generation-pipeline[bot]ci.datadog-api-spec
andauthored
Remove notify_no_data default (#1732)
Co-authored-by: ci.datadog-api-spec <[email protected]>
1 parent 235c18a commit 34d2891

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

.apigentools-info

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
"spec_versions": {
55
"v1": {
66
"apigentools_version": "1.6.6",
7-
"regenerated": "2023-10-24 18:01:02.090771",
8-
"spec_repo_commit": "7e490450"
7+
"regenerated": "2023-10-25 09:00:22.540949",
8+
"spec_repo_commit": "9ebdefa4"
99
},
1010
"v2": {
1111
"apigentools_version": "1.6.6",
12-
"regenerated": "2023-10-24 18:01:02.104260",
13-
"spec_repo_commit": "7e490450"
12+
"regenerated": "2023-10-25 09:00:22.569393",
13+
"spec_repo_commit": "9ebdefa4"
1414
}
1515
}
1616
}

.generator/schemas/v1/openapi.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6773,9 +6773,8 @@ components:
67736773
type: string
67746774
type: array
67756775
notify_no_data:
6776-
default: false
67776776
description: A Boolean indicating whether this monitor notifies when data
6778-
stops reporting.
6777+
stops reporting. Defaults to `false`.
67796778
type: boolean
67806779
on_missing_data:
67816780
$ref: '#/components/schemas/OnMissingDataOption'

src/datadog_api_client/v1/model/monitor_options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ def __init__(
257257
Setting ``notify_by`` to ``[*]`` configures the monitor to notify as a simple-alert.
258258
:type notify_by: [str], optional
259259
260-
:param notify_no_data: A Boolean indicating whether this monitor notifies when data stops reporting.
260+
:param notify_no_data: A Boolean indicating whether this monitor notifies when data stops reporting. Defaults to ``false``.
261261
:type notify_no_data: bool, optional
262262
263263
:param on_missing_data: Controls how groups or monitors are treated if an evaluation does not return any data points.

tests/v1/features/monitors.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ Feature: Monitors
157157
Scenario: Edit a monitor returns "Bad Request" response
158158
Given new "UpdateMonitor" request
159159
And request contains "monitor_id" parameter from "REPLACE.ME"
160-
And body with value {"options": {"evaluation_delay": null, "include_tags": true, "min_failure_duration": 0, "min_location_failed": 1, "new_group_delay": null, "new_host_delay": 300, "no_data_timeframe": null, "notification_preset_name": "show_all", "notify_audit": false, "notify_by": [], "notify_no_data": false, "on_missing_data": "default", "renotify_interval": null, "renotify_occurrences": null, "renotify_statuses": ["alert"], "scheduling_options": {"custom_schedule": {"recurrences": [{"rrule": "FREQ=WEEKLY;BYDAY=MO,TU,WE,TH,FR", "start": "2023-08-31T16:30:00", "timezone": "Europe/Paris"}]}, "evaluation_window": {"day_starts": "04:00", "hour_starts": 0, "month_starts": 1}}, "synthetics_check_id": null, "threshold_windows": {"recovery_window": null, "trigger_window": null}, "thresholds": {"critical_recovery": null, "ok": null, "unknown": null, "warning": null, "warning_recovery": null}, "timeout_h": null, "variables": [{"compute": {"aggregation": "avg", "interval": 60000, "metric": "@duration"}, "data_source": "rum", "group_by": [{"facet": "status", "limit": 10, "sort": {"aggregation": "avg", "order": "desc"}}], "indexes": ["days-3", "days-7"], "name": "query_errors", "search": {"query": "service:query"}}]}, "restricted_roles": [], "tags": [], "type": "query alert"}
160+
And body with value {"options": {"evaluation_delay": null, "include_tags": true, "min_failure_duration": 0, "min_location_failed": 1, "new_group_delay": null, "new_host_delay": 300, "no_data_timeframe": null, "notification_preset_name": "show_all", "notify_audit": false, "notify_by": [], "on_missing_data": "default", "renotify_interval": null, "renotify_occurrences": null, "renotify_statuses": ["alert"], "scheduling_options": {"custom_schedule": {"recurrences": [{"rrule": "FREQ=WEEKLY;BYDAY=MO,TU,WE,TH,FR", "start": "2023-08-31T16:30:00", "timezone": "Europe/Paris"}]}, "evaluation_window": {"day_starts": "04:00", "hour_starts": 0, "month_starts": 1}}, "synthetics_check_id": null, "threshold_windows": {"recovery_window": null, "trigger_window": null}, "thresholds": {"critical_recovery": null, "ok": null, "unknown": null, "warning": null, "warning_recovery": null}, "timeout_h": null, "variables": [{"compute": {"aggregation": "avg", "interval": 60000, "metric": "@duration"}, "data_source": "rum", "group_by": [{"facet": "status", "limit": 10, "sort": {"aggregation": "avg", "order": "desc"}}], "indexes": ["days-3", "days-7"], "name": "query_errors", "search": {"query": "service:query"}}]}, "restricted_roles": [], "tags": [], "type": "query alert"}
161161
When the request is sent
162162
Then the response status is 400 Bad Request
163163

0 commit comments

Comments
 (0)