Fix service definition name for v2.1 schema tests (#1393)

Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>

Author: api-clients-generation-pipeline[bot]

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-03-29 13:52:26.833708",
-            "spec_repo_commit": "1f3268e7"
+            "regenerated": "2023-03-29 17:57:23.251037",
+            "spec_repo_commit": "c0790f05"
         },
         "v2": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-03-29 13:52:26.848231",
-            "spec_repo_commit": "1f3268e7"
+            "regenerated": "2023-03-29 17:57:23.268567",
+            "spec_repo_commit": "c0790f05"
         }
     }
 }

examples/v2/service-definition/CreateOrUpdateServiceDefinitions_2619874414.py

@@ -23,7 +23,7 @@
             type=ServiceDefinitionV2Dot1EmailType.EMAIL,
         ),
     ],
-    dd_service="service-Example-Create_or_update_service_definition_using_schema_v2_1_returns_CREATED_response",
+    dd_service="service-examplecreateorupdateservicedefinitionusingschemav21returnscreatedresponse",
     extensions=dict([("myorgextension", "extensionvalue")]),
     integrations=ServiceDefinitionV2Dot1Integrations(
         opsgenie=ServiceDefinitionV2Dot1Opsgenie(

tests/v2/cassettes/test_scenarios/test_create_or_update_service_definition_using_schema_v21_returns_created_response.frozen

@@ -1 +1 @@
-2023-03-28T20:28:44.080Z
+2023-03-29T17:51:36.535Z

tests/v2/cassettes/test_scenarios/test_create_or_update_service_definition_using_schema_v21_returns_created_response.yaml

@@ -1,6 +1,6 @@
 interactions:
 - request:
-    body: '{"contacts":[{"contact":"[email protected]","name":"Team Email","type":"email"}],"dd-service":"service-Test-Create_or_update_service_definition_using_schema_v2_1_returns_CREATED_response-1680035324","extensions":{"myorgextension":"extensionvalue"},"integrations":{"opsgenie":{"region":"US","service-url":"https://my-org.opsgenie.com/service/123e4567-e89b-12d3-a456-426614174000"},"pagerduty":{"service-url":"https://my-org.pagerduty.com/service-directory/PMyService"}},"links":[{"name":"Runbook","type":"runbook","url":"https://my-runbook"},{"name":"Source
+    body: '{"contacts":[{"contact":"[email protected]","name":"Team Email","type":"email"}],"dd-service":"service-testcreateorupdateservicedefinitionusingschemav21returnscreatedresponse1680112296","extensions":{"myorgextension":"extensionvalue"},"integrations":{"opsgenie":{"region":"US","service-url":"https://my-org.opsgenie.com/service/123e4567-e89b-12d3-a456-426614174000"},"pagerduty":{"service-url":"https://my-org.pagerduty.com/service-directory/PMyService"}},"links":[{"name":"Runbook","type":"runbook","url":"https://my-runbook"},{"name":"Source
       Code","provider":"GitHub","type":"repo","url":"https://github.com/DataDog/schema"},{"name":"Architecture","provider":"Gigoogle
       drivetHub","type":"doc","url":"https://my-runbook"}],"schema-version":"v2.1","tags":["my:tag","service:tag"],"team":"my-team"}'
     headers:
@@ -12,7 +12,7 @@ interactions:
     uri: https://api.datadoghq.com/api/v2/services/definitions
   response:
     body:
-      string: '{"data":[{"type":"service-definition","attributes":{"meta":{"last-modified-time":"2023-03-28T20:28:44.264527027Z","github-html-url":"","ingestion-source":"api","origin":"unknown","origin-detail":"","warnings":[],"ingested-schema-version":"v2.1"},"schema":{"schema-version":"v2.1","dd-service":"service-test-create_or_update_service_definition_using_schema_v2_1_returns_created_response-1680035324","team":"my-team","contacts":[{"name":"Team
+      string: '{"data":[{"type":"service-definition","attributes":{"meta":{"last-modified-time":"2023-03-29T17:51:36.683797279Z","github-html-url":"","ingestion-source":"api","origin":"unknown","origin-detail":"","warnings":[],"ingested-schema-version":"v2.1"},"schema":{"schema-version":"v2.1","dd-service":"service-testcreateorupdateservicedefinitionusingschemav21returnscreatedresponse1680112296","team":"my-team","contacts":[{"name":"Team
         Email","type":"email","contact":"[email protected]"}],"links":[{"name":"Runbook","type":"runbook","url":"https://my-runbook"},{"name":"Source
         Code","type":"repo","provider":"GitHub","url":"https://github.com/DataDog/schema"},{"name":"Architecture","type":"doc","provider":"Gigoogle
         drivetHub","url":"https://my-runbook"}],"tags":["my:tag","service:tag"],"integrations":{"pagerduty":{"service-url":"https://my-org.pagerduty.com/service-directory/PMyService"},"opsgenie":{"service-url":"https://my-org.opsgenie.com/service/123e4567-e89b-12d3-a456-426614174000","region":"US"}},"extensions":{"myorgextension":"extensionvalue"}}}}]}
@@ -30,16 +30,14 @@ interactions:
       accept:
       - '*/*'
     method: DELETE
-    uri: https://api.datadoghq.com/api/v2/services/definitions/service-test-create_or_update_service_definition_using_schema_v2_1_returns_created_response-1680035324
+    uri: https://api.datadoghq.com/api/v2/services/definitions/service-testcreateorupdateservicedefinitionusingschemav21returnscreatedresponse1680112296
   response:
     body:
-      string: '{"errors":["Not Found"],"error_details":[{}]}
-
-        '
+      string: ''
     headers:
       content-type:
-      - application/json
+      - text/html; charset=utf-8
     status:
-      code: 404
-      message: Not Found
+      code: 204
+      message: No Content
 version: 1

tests/v2/features/service_definition.feature

@@ -40,11 +40,11 @@ Feature: Service Definition
   @team:DataDog/service-catalog
   Scenario: Create or update service definition using schema v2-1 returns "CREATED" response
     Given new "CreateOrUpdateServiceDefinitions" request
-    And body with value {"contacts":[{"contact":"[email protected]","name":"Team Email","type":"email"}],"dd-service":"service-{{ unique }}","extensions":{"myorgextension":"extensionvalue"},"integrations":{"opsgenie":{"region":"US","service-url":"https://my-org.opsgenie.com/service/123e4567-e89b-12d3-a456-426614174000"},"pagerduty":{"service-url":"https://my-org.pagerduty.com/service-directory/PMyService"}},"links":[{"name":"Runbook","type":"runbook","url":"https://my-runbook"},{"name":"Source Code","type":"repo","provider":"GitHub","url":"https://github.com/DataDog/schema"},{"name":"Architecture","type":"doc","provider":"Gigoogle drivetHub","url":"https://my-runbook"}],"schema-version":"v2.1","tags":["my:tag","service:tag"],"team":"my-team"}
+    And body with value {"contacts":[{"contact":"[email protected]","name":"Team Email","type":"email"}],"dd-service":"service-{{ unique_lower_alnum }}","extensions":{"myorgextension":"extensionvalue"},"integrations":{"opsgenie":{"region":"US","service-url":"https://my-org.opsgenie.com/service/123e4567-e89b-12d3-a456-426614174000"},"pagerduty":{"service-url":"https://my-org.pagerduty.com/service-directory/PMyService"}},"links":[{"name":"Runbook","type":"runbook","url":"https://my-runbook"},{"name":"Source Code","type":"repo","provider":"GitHub","url":"https://github.com/DataDog/schema"},{"name":"Architecture","type":"doc","provider":"Gigoogle drivetHub","url":"https://my-runbook"}],"schema-version":"v2.1","tags":["my:tag","service:tag"],"team":"my-team"}
     When the request is sent
     Then the response status is 200 CREATED
     And the response "data[0].attributes.meta.ingested-schema-version" is equal to "v2.1"
-    And the response "data[0].attributes.schema.dd-service" is equal to "service-{{ unique_lower }}"
+    And the response "data[0].attributes.schema.dd-service" is equal to "service-{{ unique_lower_alnum }}"
 
   @generated @skip @team:DataDog/service-catalog
   Scenario: Delete a single service definition returns "Bad Request" response