Skip to content

Commit 0ef253f

Browse files
AliDatadogwdhif
authored andcommitted
fix unit tests using global state
1 parent 221f7a3 commit 0ef253f

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

statsd/end_to_end_udp_test.go

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,10 @@ func TestContainerIDWithEntityID(t *testing.T) {
110110
resetContainerID()
111111

112112
entityIDEnvName := "DD_ENTITY_ID"
113-
defer func() { os.Unsetenv(entityIDEnvName) }()
113+
defer func() {
114+
os.Unsetenv(entityIDEnvName)
115+
resetContainerID()
116+
}()
114117
os.Setenv(entityIDEnvName, "pod-uid")
115118

116119
expectedTags := []string{"dd.internal.entity_id:pod-uid"}
@@ -123,14 +126,18 @@ func TestContainerIDWithEntityID(t *testing.T) {
123126

124127
sort.Strings(client.tags)
125128
assert.Equal(t, expectedTags, client.tags)
126-
ts.assertContainerID(t, "")
129+
ts.assertContainerID(t, "fake-container-id")
127130
ts.sendAllAndAssert(t, client)
128131
}
129132

130133
func TestContainerIDWithoutEntityID(t *testing.T) {
131134
resetContainerID()
132135
os.Unsetenv("DD_ENTITY_ID")
133136

137+
defer func() {
138+
resetContainerID()
139+
}()
140+
134141
ts, client := newClientAndTestServer(t,
135142
"udp",
136143
"localhost:8765",
@@ -164,7 +171,10 @@ func TestOriginDetectionEnabledWithEntityID(t *testing.T) {
164171
resetContainerID()
165172

166173
entityIDEnvName := "DD_ENTITY_ID"
167-
defer func() { os.Unsetenv(entityIDEnvName) }()
174+
defer func() {
175+
os.Unsetenv(entityIDEnvName)
176+
resetContainerID()
177+
}()
168178
os.Setenv(entityIDEnvName, "pod-uid")
169179

170180
originDetectionEnvName := "DD_ORIGIN_DETECTION_ENABLED"
@@ -181,7 +191,7 @@ func TestOriginDetectionEnabledWithEntityID(t *testing.T) {
181191

182192
sort.Strings(client.tags)
183193
assert.Equal(t, expectedTags, client.tags)
184-
ts.assertContainerID(t, "")
194+
ts.assertContainerID(t, "fake-container-id")
185195
ts.sendAllAndAssert(t, client)
186196
}
187197

0 commit comments

Comments
 (0)