Skip to content

Commit d306e15

Browse files
authored
Do not set the hibernate or datanucleus span service name if dd.trace.remove.integration-service-names.enabled is true or the naming scheme version is v1 (#8727)
1 parent 2dd1774 commit d306e15

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

dd-java-agent/instrumentation/datanucleus-4/src/main/java/datadog/trace/instrumentation/datanucleus/DatanucleusDecorator.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package datadog.trace.instrumentation.datanucleus;
22

3+
import datadog.trace.api.naming.SpanNaming;
34
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
45
import datadog.trace.bootstrap.instrumentation.api.InternalSpanTypes;
56
import datadog.trace.bootstrap.instrumentation.api.UTF8BytesString;
@@ -16,7 +17,8 @@ public class DatanucleusDecorator extends OrmClientDecorator {
1617
public static final CharSequence DATANUCLEUS_QUERY_DELETE =
1718
UTF8BytesString.create("datanucleus.query.delete");
1819
public static final CharSequence JAVA_DATANUCLEUS = UTF8BytesString.create("java-datanucleus");
19-
20+
private static final String SERVICE_NAME =
21+
SpanNaming.instance().namingSchema().database().service("datanucleus");
2022
public static final DatanucleusDecorator DECORATE = new DatanucleusDecorator();
2123

2224
@Override
@@ -36,7 +38,7 @@ protected CharSequence component() {
3638

3739
@Override
3840
protected String service() {
39-
return "datanucleus";
41+
return SERVICE_NAME;
4042
}
4143

4244
@Override

dd-java-agent/instrumentation/hibernate/src/main/java/datadog/trace/instrumentation/hibernate/HibernateDecorator.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package datadog.trace.instrumentation.hibernate;
22

3+
import datadog.trace.api.naming.SpanNaming;
34
import datadog.trace.bootstrap.instrumentation.api.InternalSpanTypes;
45
import datadog.trace.bootstrap.instrumentation.api.UTF8BytesString;
56
import datadog.trace.bootstrap.instrumentation.decorator.OrmClientDecorator;
@@ -10,11 +11,13 @@
1011

1112
public class HibernateDecorator extends OrmClientDecorator {
1213
public static final CharSequence HIBERNATE_SESSION = UTF8BytesString.create("hibernate.session");
14+
private static final String SERVICE_NAME =
15+
SpanNaming.instance().namingSchema().database().service("hibernate");
1316
public static final HibernateDecorator DECORATOR = new HibernateDecorator();
1417

1518
@Override
1619
protected String service() {
17-
return "hibernate";
20+
return SERVICE_NAME;
1821
}
1922

2023
@Override

0 commit comments

Comments
 (0)