Skip to content

Commit 1eb40d3

Browse files
committed
Update MD051/link-fragments to not provide error context for multi-line scenarios.
1 parent ef1bd28 commit 1eb40d3

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

demo/markdownlint-browser.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6202,11 +6202,14 @@ module.exports = {
62026202
var _loop = function _loop() {
62036203
var definition = _step4.value;
62046204
if (definition.text.length > 1 && definition.text.startsWith("#") && !fragments.has(definition.text)) {
6205+
// eslint-disable-next-line no-undef-init
6206+
var context = undefined;
62056207
// eslint-disable-next-line no-undef-init
62066208
var range = undefined;
62076209
// eslint-disable-next-line no-undef-init
62086210
var fixInfo = undefined;
62096211
if (link.startLine === link.endLine) {
6212+
context = link.text;
62106213
range = [link.startColumn, link.endColumn - link.startColumn];
62116214
fixInfo = {
62126215
"editColumn": definition.startColumn,
@@ -6220,9 +6223,9 @@ module.exports = {
62206223
if (mixedCaseKey) {
62216224
// @ts-ignore
62226225
(fixInfo || {}).insertText = mixedCaseKey;
6223-
addErrorDetailIf(onError, link.startLine, mixedCaseKey, definition.text, undefined, link.text, range, fixInfo);
6226+
addErrorDetailIf(onError, link.startLine, mixedCaseKey, definition.text, undefined, context, range, fixInfo);
62246227
} else {
6225-
addError(onError, link.startLine, undefined, link.text, range);
6228+
addError(onError, link.startLine, undefined, context, range);
62266229
}
62276230
}
62286231
};

lib/md051.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,14 @@ module.exports = {
9494
definition.text.startsWith("#") &&
9595
!fragments.has(definition.text)
9696
) {
97+
// eslint-disable-next-line no-undef-init
98+
let context = undefined;
9799
// eslint-disable-next-line no-undef-init
98100
let range = undefined;
99101
// eslint-disable-next-line no-undef-init
100102
let fixInfo = undefined;
101103
if (link.startLine === link.endLine) {
104+
context = link.text;
102105
range = [ link.startColumn, link.endColumn - link.startColumn ];
103106
fixInfo = {
104107
"editColumn": definition.startColumn,
@@ -117,7 +120,7 @@ module.exports = {
117120
mixedCaseKey,
118121
definition.text,
119122
undefined,
120-
link.text,
123+
context,
121124
range,
122125
fixInfo
123126
);
@@ -126,7 +129,7 @@ module.exports = {
126129
onError,
127130
link.startLine,
128131
undefined,
129-
link.text,
132+
context,
130133
range
131134
);
132135
}

test/snapshots/markdownlint-test-scenarios.js.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23597,8 +23597,7 @@ Generated by [AVA](https://avajs.dev).
2359723597
],
2359823598
},
2359923599
{
23600-
errorContext: `[Invalid {MD051}](#multi-line␊
23601-
"Title")`,
23600+
errorContext: null,
2360223601
errorDetail: null,
2360323602
errorRange: null,
2360423603
fixInfo: null,
@@ -23667,8 +23666,7 @@ Generated by [AVA](https://avajs.dev).
2366723666
],
2366823667
},
2366923668
{
23670-
errorContext: `[Multi-line {MD051}](#NAMEDLINK␊
23671-
"Title")`,
23669+
errorContext: null,
2367223670
errorDetail: 'Expected: #namedlink; Actual: #NAMEDLINK',
2367323671
errorRange: null,
2367423672
fixInfo: null,
-20 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)