Skip to content

Commit b886207

Browse files
committed
[optimize] enable Async Render mode of DOM Renderer 2.5
1 parent 05cbd58 commit b886207

File tree

6 files changed

+47
-23
lines changed

6 files changed

+47
-23
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "web-cell",
3-
"version": "3.0.2",
3+
"version": "3.0.3-rc.0",
44
"description": "Web Components engine based on VDOM, JSX, MobX & TypeScript",
55
"keywords": [
66
"web",
@@ -27,7 +27,7 @@
2727
"types": "dist/index.d.ts",
2828
"dependencies": {
2929
"@swc/helpers": "^0.5.15",
30-
"dom-renderer": "^2.5.1",
30+
"dom-renderer": "^2.5.2-rc.0",
3131
"mobx": ">=6.11",
3232
"regenerator-runtime": "^0.14.1",
3333
"web-utility": "^4.4.2"
@@ -38,7 +38,7 @@
3838
"jsdom": ">=23.1"
3939
},
4040
"devDependencies": {
41-
"@eslint/compat": "^1.2.2",
41+
"@eslint/compat": "^1.2.3",
4242
"@eslint/js": "^9.14.0",
4343
"@parcel/config-default": "~2.13.0",
4444
"@parcel/packager-ts": "~2.13.0",

pnpm-lock.yaml

Lines changed: 16 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

preview/Clock.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99
reaction,
1010
WebCell
1111
} from '../source';
12+
import { renderMode } from './utility';
1213

1314
class ClockModel {
1415
@observable
@@ -35,7 +36,8 @@ export interface ClassClock extends WebCell {}
3536

3637
@component({
3738
tagName: 'class-clock',
38-
mode: 'open'
39+
mode: 'open',
40+
renderMode
3941
})
4042
@observer
4143
export class ClassClock extends HTMLElement implements WebCell {
@@ -46,7 +48,7 @@ export class ClassClock extends HTMLElement implements WebCell {
4648
private timer: number;
4749

4850
connectedCallback() {
49-
this.timer = setInterval(() => (this.time = new Date()), Second);
51+
this.timer = window.setInterval(() => (this.time = new Date()), Second);
5052
}
5153

5254
disconnectedCallback() {

preview/index.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@ import { DOMRenderer } from 'dom-renderer';
22
import { configure } from 'mobx';
33

44
import { HomePage } from './Home';
5+
import { renderMode } from './utility';
56

67
configure({ enforceActions: 'never' });
78

8-
new DOMRenderer().render(<HomePage />, document.querySelector('#app')!);
9+
new DOMRenderer().render(
10+
<HomePage />,
11+
document.querySelector('#app')!,
12+
renderMode
13+
);

preview/utility.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import { parseURLData } from 'web-utility';
2+
3+
export const { renderMode } = parseURLData() as { renderMode: 'sync' };

source/WebCell.tsx

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DOMRenderer, JsxProps, VNode } from 'dom-renderer';
1+
import { DOMRenderer, JsxProps, RenderMode, VNode } from 'dom-renderer';
22
import {
33
CustomElement,
44
delegate,
@@ -11,6 +11,7 @@ export interface ComponentMeta
1111
Partial<ShadowRootInit> {
1212
tagName: string;
1313
transitible?: boolean;
14+
renderMode?: RenderMode;
1415
}
1516

1617
export type ClassComponent = CustomElementConstructor;
@@ -102,6 +103,17 @@ export function component(meta: ComponentMeta) {
102103
declare render?: () => VNode;
103104
declare updatedCallback?: () => any;
104105

106+
protected updateDOM(content: VNode) {
107+
const result = this.renderer.render(
108+
content,
109+
this.root,
110+
meta.renderMode as 'async'
111+
);
112+
return result instanceof Promise
113+
? result.then(this.updatedCallback?.bind(this))
114+
: this.updatedCallback?.();
115+
}
116+
105117
async update() {
106118
const vNode = this.render?.();
107119

@@ -114,18 +126,14 @@ export function component(meta: ComponentMeta) {
114126
);
115127
if (!(content != null)) return;
116128

117-
const render = () => {
118-
this.renderer.render(content, this.root);
119-
this.updatedCallback?.();
120-
};
121129
if (
122130
!meta.transitible ||
123131
typeof document.startViewTransition !== 'function'
124132
)
125-
return render();
133+
return this.updateDOM(content);
126134

127135
const { updateCallbackDone, finished } =
128-
document.startViewTransition(render);
136+
document.startViewTransition(() => this.updateDOM(content));
129137

130138
try {
131139
await finished;

0 commit comments

Comments
 (0)