diff --git a/packages/components/src/storageUtils.ts b/packages/components/src/storageUtils.ts index 3639553e151..3f120b70057 100644 --- a/packages/components/src/storageUtils.ts +++ b/packages/components/src/storageUtils.ts @@ -384,20 +384,21 @@ export const getS3Config = () => { throw new Error('S3 storage configuration is missing') } - let credentials: S3ClientConfig['credentials'] | undefined + const s3Config: S3ClientConfig = { + region: region, + endpoint: customURL, + forcePathStyle: forcePathStyle + } + if (accessKeyId && secretAccessKey) { - credentials = { - accessKeyId, - secretAccessKey + s3Config.credentials = { + accessKeyId: accessKeyId, + secretAccessKey: secretAccessKey } } - const s3Client = new S3Client({ - credentials, - region, - endpoint: customURL, - forcePathStyle: forcePathStyle - }) + const s3Client = new S3Client(s3Config) + return { s3Client, Bucket } } diff --git a/packages/components/src/utils.ts b/packages/components/src/utils.ts index 195033e77c3..fb29c129369 100644 --- a/packages/components/src/utils.ts +++ b/packages/components/src/utils.ts @@ -27,14 +27,18 @@ if (USE_AWS_SECRETS_MANAGER) { const accessKeyId = process.env.SECRETKEY_AWS_ACCESS_KEY const secretAccessKey = process.env.SECRETKEY_AWS_SECRET_KEY - let credentials: SecretsManagerClientConfig['credentials'] | undefined + const secretManagerConfig: SecretsManagerClientConfig = { + region: region + } + if (accessKeyId && secretAccessKey) { - credentials = { + secretManagerConfig.credentials = { accessKeyId, secretAccessKey } } - secretsManagerClient = new SecretsManagerClient({ credentials, region }) + + secretsManagerClient = new SecretsManagerClient(secretManagerConfig) } /* diff --git a/packages/server/src/utils/index.ts b/packages/server/src/utils/index.ts index cfb70ec1e2c..3aa371500d5 100644 --- a/packages/server/src/utils/index.ts +++ b/packages/server/src/utils/index.ts @@ -76,14 +76,17 @@ if (USE_AWS_SECRETS_MANAGER) { const accessKeyId = process.env.SECRETKEY_AWS_ACCESS_KEY const secretAccessKey = process.env.SECRETKEY_AWS_SECRET_KEY - let credentials: SecretsManagerClientConfig['credentials'] | undefined + const secretManagerConfig: SecretsManagerClientConfig = { + region: region + } + if (accessKeyId && secretAccessKey) { - credentials = { + secretManagerConfig.credentials = { accessKeyId, secretAccessKey } } - secretsManagerClient = new SecretsManagerClient({ credentials, region }) + secretsManagerClient = new SecretsManagerClient(secretManagerConfig) } export const databaseEntities: IDatabaseEntity = { diff --git a/packages/server/src/utils/logger.ts b/packages/server/src/utils/logger.ts index a7847daf12b..c49670aa05a 100644 --- a/packages/server/src/utils/logger.ts +++ b/packages/server/src/utils/logger.ts @@ -25,19 +25,17 @@ if (process.env.STORAGE_TYPE === 's3') { throw new Error('S3 storage configuration is missing') } - let credentials: S3ClientConfig['credentials'] | undefined - if (accessKeyId && secretAccessKey) { - credentials = { - accessKeyId, - secretAccessKey - } - } - const s3Config: S3ClientConfig = { region: region, endpoint: customURL, - forcePathStyle: forcePathStyle, - credentials: credentials + forcePathStyle: forcePathStyle + } + + if (accessKeyId && secretAccessKey) { + s3Config.credentials = { + accessKeyId: accessKeyId, + secretAccessKey: secretAccessKey + } } s3ServerStream = new S3StreamLogger({