Skip to content

Commit 8c8649c

Browse files
committed
Remove "turn device screen on" feature
Only keep "turn device screen off" and POWER button. After we turn the device screen off (with Ctrl+o), turning it back on does not always work, and leaves the device in a weird state, where even the power button may not be sufficient: <#175 (comment)> This is not an acceptable behavior, so disable the shortcut to turn the physical device screen on. We can use the POWER button (or Ctrl+p) instead.
1 parent e572d81 commit 8c8649c

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ you are interested, see [issue 14].
286286
| click on `POWER` | `Ctrl`+`p` |
287287
| power on | _Right-click²_ |
288288
| turn device screen off (keep mirroring)| `Ctrl`+`o` |
289-
| turn device screen on | `Ctrl`+`Shift`+`o` |
290289
| expand notification panel | `Ctrl`+`n` |
291290
| collapse notification panel | `Ctrl`+`Shift`+`n` |
292291
| copy device clipboard to computer | `Ctrl`+`c` |

app/src/input_manager.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -282,11 +282,8 @@ input_manager_process_key(struct input_manager *input_manager,
282282
}
283283
return;
284284
case SDLK_o:
285-
if (control && ctrl && !meta && down) {
286-
enum screen_power_mode mode = shift
287-
? SCREEN_POWER_MODE_NORMAL
288-
: SCREEN_POWER_MODE_OFF;
289-
set_screen_power_mode(controller, mode);
285+
if (control && ctrl && !shift && !meta && down) {
286+
set_screen_power_mode(controller, SCREEN_POWER_MODE_OFF);
290287
}
291288
return;
292289
case SDLK_DOWN:

app/src/main.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,6 @@ static void usage(const char *arg0) {
134134
" Ctrl+o\n"
135135
" turn device screen off (keep mirroring)\n"
136136
"\n"
137-
" Ctrl+Shift+o\n"
138-
" turn device screen on\n"
139-
"\n"
140137
" Ctrl+n\n"
141138
" expand notification panel\n"
142139
"\n"

0 commit comments

Comments
 (0)