Skip to content

Drop dependency on Java/server #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luke-jr opened this issue Feb 12, 2020 · 1 comment
Closed

Drop dependency on Java/server #1145

luke-jr opened this issue Feb 12, 2020 · 1 comment
Labels

Comments

@luke-jr
Copy link

luke-jr commented Feb 12, 2020

Is there any reason this can't just use the native screenrecord and input CLI tools?

@rom1v
Copy link
Collaborator

rom1v commented Feb 13, 2020

For input:

For video:

  • screenrecord is limited to 180 seconds
  • buffering issues with adb shell stdout (a frame could be written but stay in buffer)
  • reduced frame latency Reduce latency by 1 frame #646
  • correctly handle rotation
  • correctly handle resize without adding unwanted black borders (when one dimension is not multiple of 8)

For info, I used the output of screenrecord for the initial PoC, killing it and restarting it on every rotation and every 3 minutes (which by the way produced a corrupted stream), it worked but was very hacky.

@rom1v rom1v added the question label Feb 13, 2020
@rom1v rom1v closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants