Skip to content

google_container_node_pool: Support PMU on Node Pools #22266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schallert opened this issue Apr 8, 2025 · 1 comment · May be fixed by GoogleCloudPlatform/magic-modules#14144
Open

google_container_node_pool: Support PMU on Node Pools #22266

schallert opened this issue Apr 8, 2025 · 1 comment · May be fixed by GoogleCloudPlatform/magic-modules#14144

Comments

@schallert
Copy link

schallert commented Apr 8, 2025

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Some VM families support a performance monitoring unit (PMU). This is enabled by setting advancedMachineFeatures.performanceMonitoringUnit on the VM.

The GKE node pull resource supports advanced_machine_features, but does not have a field for the PMU. It would be great if it did.

New or Affected Resource(s)

  • google_container_node_pool

Potential Terraform Configuration

advanced_machine_features {
  performance_monitoring_unit = "ARCHITECTURAL|STANDARD|ENHANCED"
}

References

No response

b/410577734

@github-actions github-actions bot added forward/review In review; remove label to forward service/container labels Apr 8, 2025
@rileykarson rileykarson added size/s and removed forward/review In review; remove label to forward labels Apr 14, 2025
@rileykarson rileykarson added this to the Goals milestone Apr 14, 2025
@ramonvermeulen
Copy link

ramonvermeulen commented May 4, 2025

@schallert

I think unfortunately this feature can only be implemented when it is supported in the underlaying v1 or v1beta1 API, which seems not to be the case:

https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/NodeConfig#advancedmachinefeatures
https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/NodeConfig#AdvancedMachineFeatures

Has to be implemented in the REST API first before it can be added to the terraform resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants