CS: Relaxed EarlyExit rule (doctrine#891)

Author: GromNaN

phpcs.xml.dist

@@ -43,4 +43,12 @@
     <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInCall.MissingTrailingComma">
         <exclude-pattern>src/Command/*</exclude-pattern>
     </rule>
+
+    <rule ref="SlevomatCodingStandard.ControlStructures.EarlyExit">
+        <properties>
+            <property name="ignoreStandaloneIfInScope" value="true"/>
+            <property name="ignoreOneLineTrailingIf" value="true"/>
+            <property name="ignoreTrailingIfWithOneInstruction" value="true"/>
+        </properties>
+    </rule>
 </ruleset>

src/DependencyInjection/Compiler/FixturesCompilerPass.php

@@ -26,11 +26,9 @@ public function process(ContainerBuilder $container): void
         foreach ($taggedServices as $serviceId => $tags) {
             $groups = [];
             foreach ($tags as $tagData) {
-                if (! isset($tagData['group'])) {
-                    continue;
+                if (isset($tagData['group'])) {
+                    $groups[] = $tagData['group'];
                 }
-
-                $groups[] = $tagData['group'];
             }
 
             $fixtures[] = [

src/DependencyInjection/DoctrineMongoDBExtension.php

@@ -205,14 +205,12 @@ protected function overrideParameters(array $options, ContainerBuilder $containe
         ];
 
         foreach ($overrides as $key) {
-            if (! isset($options[$key])) {
-                continue;
-            }
-
-            $container->setParameter('doctrine_mongodb.odm.' . $key, $options[$key]);
+            if (isset($options[$key])) {
+                $container->setParameter('doctrine_mongodb.odm.' . $key, $options[$key]);
 
-            // the option should not be used, the parameter should be referenced
-            unset($options[$key]);
+                // the option should not be used, the parameter should be referenced
+                unset($options[$key]);
+            }
         }
 
         return $options;
@@ -325,11 +323,9 @@ protected function loadDocumentManager(array $documentManager, string|null $defa
         foreach ($documentManager['filters'] as $name => $filter) {
             $parameters = $filter['parameters'] ?? [];
             $odmConfigDef->addMethodCall('addFilter', [$name, $filter['class'], $parameters]);
-            if (! $filter['enabled']) {
-                continue;
+            if ($filter['enabled']) {
+                $enabledFilters[] = $name;
             }
-
-            $enabledFilters[] = $name;
         }
 
         $managerConfiguratorName = sprintf('doctrine_mongodb.odm.%s_manager_configurator', $documentManager['name']);
@@ -534,11 +530,9 @@ protected function loadDocumentManagerBundlesMappingInformation(array $documentM
             // TODO: Can we make a method out of it on Definition? replaceMethodArguments() or something.
             $calls = $odmConfigDef->getMethodCalls();
             foreach ($calls as $call) {
-                if ($call[0] !== 'setDocumentNamespaces') {
-                    continue;
+                if ($call[0] === 'setDocumentNamespaces') {
+                    $this->aliasMap = array_merge($call[1][0], $this->aliasMap);
                 }
-
-                $this->aliasMap = array_merge($call[1][0], $this->aliasMap);
             }
 
             $method = $odmConfigDef->removeMethodCall('setDocumentNamespaces');