fix tests

Author: phillipthelen

habitica-images

@@ -150,7 +150,7 @@ describe('emails', () => {
 
       sendTxn(mailingInfo, emailType);
       expect(got.post).to.be.called;
-      expect(got.post).to.be.calledWith('undefined/job', sinon.match({
+      expect(got.post).to.be.calledWith('http://example.com/job', sinon.match({
         json: {
           data: {
             emailType: sinon.match.same(emailType),
@@ -234,7 +234,7 @@ describe('emails', () => {
 
       sendTxn(mailingInfo, emailType);
       expect(got.post).to.be.called;
-      expect(got.post).to.be.calledWith('undefined/job', sinon.match({
+      expect(got.post).to.be.calledWith('http://example.com/job', sinon.match({
         json: {
           data: {
             emailType: sinon.match.same(emailType),
@@ -254,7 +254,7 @@ describe('emails', () => {
 
       sendTxn(mailingInfo, emailType, variables);
       expect(got.post).to.be.called;
-      expect(got.post).to.be.calledWith('undefined/job', sinon.match({
+      expect(got.post).to.be.calledWith('http://example.com/job', sinon.match({
         json: {
           data: {
             variables: sinon.match(value => value[0].name === 'BASE_URL', 'matches variables'),

test/api/unit/libs/email.test.js

@@ -2,7 +2,6 @@ import got from 'got';
 import nconf from 'nconf';
 import logger from './logger';
 
-const IS_PROD = nconf.get('IS_PROD');
 const EMAIL_SERVER = {
   url: nconf.get('EMAIL_SERVER_URL'),
   auth: {
@@ -12,26 +11,23 @@ const EMAIL_SERVER = {
 };
 
 export function sendJob (type, config) {
-  if (IS_PROD) {
-    const { data, options } = config;
-    const usedOptions = {
-      backoff: { delay: 10 * 60 * 1000, type: 'exponential' },
-      ...options,
-    };
+  const { data, options } = config;
+  const usedOptions = {
+    backoff: { delay: 10 * 60 * 1000, type: 'exponential' },
+    ...options,
+  };
 
-    return got.post(`${EMAIL_SERVER.url}/job`, {
-      retry: 5, // retry the http request to the email server 5 times
-      timeout: 60000, // wait up to 60s before timing out
-      username: EMAIL_SERVER.auth.user,
-      password: EMAIL_SERVER.auth.password,
-      json: {
-        type,
-        data,
-        options: usedOptions,
-      },
-    }).json().catch(err => logger.error(err, {
-      extraMessage: 'Error while sending an email.',
-    }));
-  }
-  return null;
+  return got.post(`${EMAIL_SERVER.url}/job`, {
+    retry: 5, // retry the http request to the email server 5 times
+    timeout: 60000, // wait up to 60s before timing out
+    username: EMAIL_SERVER.auth.user,
+    password: EMAIL_SERVER.auth.password,
+    json: {
+      type,
+      data,
+      options: usedOptions,
+    },
+  }).json().catch(err => logger.error(err, {
+    extraMessage: 'Error while sending an email.',
+  }));
 }