You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
onLaunchedWithItems is implemented by passing fields through the querystring with an item. prefix. The query params are set here and read here. The way it is currently implemented - on both sides - has property duplication which makes this code prone to missing information about these items.
One way we can fix the property duplication is by using iteration from a single source for fsitem properties. We don't have any sort of model/DTO/schema getter endpoint on backend though, so this still requires duplicating the property list on frontend or implementing this model getter. Another option is to iterate over the fsitem properties on send-side and then iterate over item. query params in receive side which avoids this added complexity and should work fine. However, filesystem items are not constrained to 2048 characters while URLs are, and even half that or less might become an issue for apps with other open args; copying all the file item information through the URL therefore might be a bad idea.
My suggested solution is to only pass the file UUID to apps after granting the app permission to access the file (a user-to-app permission) though the current permission system (rather than using the /sign endpoint). onLaunchedWithItems will then fetch the file information via puter.js the same way everything else does.
The text was updated successfully, but these errors were encountered:
- Modified launch_app.js to only pass file UUID to apps\n- Updated UI.js to fetch complete file information using puter.fs.stat()\n- Ensures consistent file information and avoids URL length limitations\n\nFixes #1226
ai: true
Partly fixed with mycoder by #1230 except it doesn't use /sign (causing a regression) and doesn't grant permission (causing it to not work at all). Attempts to fix this by further prompting is resulting in relentless 429 errors from Claude (thanks Claude) so this will likely need to completed manually.
onLaunchedWithItems
is implemented by passing fields through the querystring with anitem.
prefix. The query params are set here and read here. The way it is currently implemented - on both sides - has property duplication which makes this code prone to missing information about these items.One way we can fix the property duplication is by using iteration from a single source for fsitem properties. We don't have any sort of model/DTO/schema getter endpoint on backend though, so this still requires duplicating the property list on frontend or implementing this model getter. Another option is to iterate over the fsitem properties on send-side and then iterate over
item.
query params in receive side which avoids this added complexity and should work fine. However, filesystem items are not constrained to 2048 characters while URLs are, and even half that or less might become an issue for apps with other open args; copying all the file item information through the URL therefore might be a bad idea.My suggested solution is to only pass the file UUID to apps after granting the app permission to access the file (a
user-to-app
permission) though the current permission system (rather than using the/sign
endpoint).onLaunchedWithItems
will then fetch the file information via puter.js the same way everything else does.The text was updated successfully, but these errors were encountered: