Skip to content

igx-excel-filter missing valid ARIA parents role #10391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GibletJr opened this issue Oct 28, 2021 · 0 comments · Fixed by #10515
Closed

igx-excel-filter missing valid ARIA parents role #10391

GibletJr opened this issue Oct 28, 2021 · 0 comments · Fixed by #10515
Assignees
@igdmdimitrov
Labels
aria-support 🐛 bug Any issue that describes a bug version: 12.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@GibletJr
Copy link

GibletJr commented Oct 28, 2021 •
edited
Loading

Description

According to the w3 aria specification, any element with a role set to menuitem should contain a parent set to the following roles: menu, menubar, group

Currently, there is no parent role set for the igx-excel-filter

element.

igniteui-angular version: 12.1.x
browser: any

Steps to reproduce

  1. Install the Accessibility Insights extension for chrome
  2. Create an example igx-grid control setting the filterMode attribute to excelStyleFilter
  3. Click on the column filter icon to open the filter options window.
  4. Run the FastPass check from the notification Launch Pad

Result

image

Expected result

igx-excel-filter component should be compliant to w3 aria spec

Attachments

Attach a sample if available, and screenshots, if applicable.
@GibletJr GibletJr added the 🐛 bug Any issue that describes a bug label Oct 28, 2021
@GibletJr GibletJr mentioned this issue Oct 28, 2021
Closed
@igdmdimitrov igdmdimitrov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Nov 15, 2021
This was referenced Nov 16, 2021
Merged
Merged
Merged
@igdmdimitrov igdmdimitrov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 22, 2021
@igdmdimitrov igdmdimitrov mentioned this issue Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igdmdimitrov igdmdimitrov

Labels
aria-support 🐛 bug Any issue that describes a bug version: 12.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(esf): added role=menu to esf article - master IgniteUI/igniteui-angular
4 participants
@zdrawku @gedinakova @igdmdimitrov @GibletJr