Skip to content

Icon is not shown when addSvgIcon is used without passing a fontFamily #9975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Aleksandyr opened this issue Aug 6, 2021 · 1 comment · Fixed by #10274 or #10279
Closed

Icon is not shown when addSvgIcon is used without passing a fontFamily #9975

Aleksandyr opened this issue Aug 6, 2021 · 1 comment · Fixed by #10274 or #10279
Assignees
@simeonoff
Labels
🐛 bug Any issue that describes a bug 🖼️ icon version: 12.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Aleksandyr
Copy link
Contributor

Description

Icon is not shown when addSvgIcon is used without being passed a fontFamily

  • igniteui-angular version:
  • browser:

Steps to reproduce

  1. Open this sample
  2. Try removing fontFamily prop definition from either the template or from addSvgIcon method

Result

Icon is not shown

Expected result

Icon should be shown as it is described in the documentation
The icon name and file URL path are the method's mandatory parameters; family can be specified as well.
@Aleksandyr Aleksandyr changed the title Icon is not shown when addSvgIcon is used without being passed a fontFamily Icon is not shown when addSvgIcon is used without passing a fontFamily Aug 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Oct 6, 2021
@zdrawku zdrawku removed the status: inactive Used to stale issues and pull requests label Oct 7, 2021
@zdrawku zdrawku mentioned this issue Oct 7, 2021
Merged
14 tasks
@simeonoff simeonoff self-assigned this Oct 11, 2021
@simeonoff simeonoff added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 11, 2021
This was referenced Oct 11, 2021
Merged
Merged
@simeonoff simeonoff linked a pull request Oct 11, 2021 that will close this issue
fix(icon-service): can't register icon w/o family #10279
Merged
14 tasks
@simeonoff simeonoff added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

Labels
🐛 bug Any issue that describes a bug 🖼️ icon version: 12.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
3 participants
@simeonoff @Aleksandyr @zdrawku