Skip to content

Commit 12a47f5

Browse files
helloanoopIts-treason
authored andcommitted
fix(usebruno#1810): handled error case responseTime
1 parent e3fb947 commit 12a47f5

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/bruno-electron/src/ipc/network/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -921,15 +921,15 @@ const registerNetworkIpc = (mainWindow) => {
921921
);
922922

923923
timeStart = Date.now();
924-
let response,responseTime;
924+
let response, responseTime;
925925
try {
926926
/** @type {import('axios').AxiosResponse} */
927927
response = await axiosInstance(request);
928928
timeEnd = Date.now();
929929

930930
const { data, dataBuffer } = parseDataFromResponse(response);
931931
response.data = data;
932-
response.responseTime = response.headers.get('request-duration')
932+
response.responseTime = response.headers.get('request-duration');
933933

934934
mainWindow.webContents.send('main:run-folder-event', {
935935
type: 'response-received',
@@ -941,7 +941,7 @@ const registerNetworkIpc = (mainWindow) => {
941941
dataBuffer: dataBuffer.toString('base64'),
942942
size: Buffer.byteLength(dataBuffer),
943943
data: response.data,
944-
responseTime : response.headers.get('request-duration')
944+
responseTime: response.headers.get('request-duration')
945945
},
946946
...eventData
947947
});
@@ -959,7 +959,7 @@ const registerNetworkIpc = (mainWindow) => {
959959
dataBuffer: dataBuffer.toString('base64'),
960960
size: Buffer.byteLength(dataBuffer),
961961
data: error.response.data,
962-
responseTime: response.headers.get('request-duration')
962+
responseTime: error.response.headers.get('request-duration')
963963
};
964964

965965
// if we get a response from the server, we consider it as a success

packages/bruno-tests/collection/ping.bru

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ vars:pre-request {
2626

2727
assert {
2828
res.status: eq 200
29+
res.responseTime: lte 2000
2930
~res.body: eq {{pong}}
3031
}
3132

0 commit comments

Comments
 (0)