comment on rng copy

Author: hexaeder

src/sfdp.jl

@@ -108,10 +108,10 @@ function Base.iterate(iter::LayoutIterator{<:SFDP}, state)
             end
         end
         if any(isnan, force)
-            # if two points are at the exact same location
-            # use random force in any direction
-            rng = copy(algo.rng)
-            force += randn(rng, Ftype)
+            # if two points are at the exact same location use random force in any direction
+            # copy rng from alg struct to not advance the "initial" rng state
+            # otherwise algo(g)==algo(g) might be broken
+            force += randn(copy(algo.rng), Ftype)
         end
         mask = (!).(pin[i]) # where pin=true mask will multiply with 0
         locs[i] = locs[i] .+ (step .* (force ./ norm(force))) .* mask

src/spring.jl

@@ -114,8 +114,9 @@ function Base.iterate(iter::LayoutIterator{<:Spring}, state)
             else
                 # if two points are at the exact same location
                 # use random force in any direction
-                rng = copy(algo.rng)
-                force_vec += randn(rng, Ftype)
+                # copy rng from alg struct to not advance the "initial" rng state
+                # otherwise algo(g)==algo(g) might be broken
+                force_vec += randn(copy(algo.rng), Ftype)
             end
 
         end