-
Notifications
You must be signed in to change notification settings - Fork 11
ELFVersion.jl additions #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 68.09% 69.00% +0.90%
==========================================
Files 46 46
Lines 1332 1371 +39
==========================================
+ Hits 907 946 +39
Misses 425 425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nightly won't work at the moment due to JuliaLang/julia#57699 |
c9463db
to
72121f6
Compare
Can you add some tests for the new functionality? 🙂 |
72121f6
to
4ef64df
Compare
`ELFVersionNeededData` should produce a list of `ELFVersionNeededEntry` just as `ELFVersionData` produces a list of `ELFVersionEntry`. Export both and add docs + tests.
4abb742
to
c357a27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! Easy to read, and test coverage looks good.
Thanks much @mlechu !
@giordano or @staticfloat , is it possible to get a quick review here? Changes look complete to me, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I used ObjectFile to write a script to patch versions in ELF files and decided some parts of it might belong here.
ELFVersionData
not working if it doesn't find a.gnu.version_d
section:ELFVersionNeededData
, a similar function for version requirements (.gnu.version_r
)