You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The type definitions for Ginibre, GaussianHermite, GaussianJacobi, Ginibre, and Haar are wonky, and they could all become parametric immutable types instead. Below, I list their definitions and suggest improvements, some of which are breaking:
@dlfivefifty please let me know your thoughts, I'm happy to implement these changes. I'm also aware that I'm new to this old package, so I won't be upset if you turn down this proposal 😄
The text was updated successfully, but these errors were encountered:
The type definitions for
Ginibre
,GaussianHermite
,GaussianJacobi
,Ginibre
, andHaar
are wonky, and they could all become parametric immutable types instead. Below, I list their definitions and suggest improvements, some of which are breaking:RandomMatrices.jl/src/GaussianEnsembles.jl
Lines 43 to 44 in fc98f3b
RandomMatrices.jl/src/GaussianEnsembles.jl
Lines 175 to 179 in fc98f3b
RandomMatrices.jl/src/GaussianEnsembles.jl
Lines 277 to 282 in fc98f3b
RandomMatrices.jl/src/Ginibre.jl
Lines 27 to 30 in fc98f3b
RandomMatrices.jl/src/Haar.jl
Lines 91 to 93 in fc98f3b
@dlfivefifty please let me know your thoughts, I'm happy to implement these changes. I'm also aware that I'm new to this old package, so I won't be upset if you turn down this proposal 😄
The text was updated successfully, but these errors were encountered: