Skip to content

Commit 1c46709

Browse files
authored
Add missing sparse constructors for AbstractQ (#346)
1 parent c4eeb2f commit 1c46709

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/sparsematrix.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -914,6 +914,8 @@ SparseMatrixCSC{Tv,Ti}(M::Adjoint{<:Any,<:AbstractSparseMatrixCSC}) where {Tv,Ti
914914
SparseMatrixCSC{Tv,Ti}(M::Transpose{<:Any,<:AbstractSparseMatrixCSC}) where {Tv,Ti} = SparseMatrixCSC{Tv,Ti}(copy(M))
915915

916916
# we can only view AbstractQs as columns
917+
SparseMatrixCSC(Q::AbstractQ{Tv}) where {Tv} = SparseMatrixCSC{Tv,Int}(Q)
918+
SparseMatrixCSC{Tv}(Q::AbstractQ{Tv}) where {Tv} = SparseMatrixCSC{Tv,Int}(Q)
917919
SparseMatrixCSC{Tv,Ti}(Q::AbstractQ) where {Tv,Ti} = sparse_with_lmul(Tv, Ti, Q)
918920

919921
"""
@@ -997,7 +999,7 @@ sparse(A::AbstractMatrix{Tv}) where {Tv} = convert(SparseMatrixCSC{Tv}, A)
997999

9981000
sparse(S::AbstractSparseMatrixCSC) = copy(S)
9991001

1000-
sparse(Q::AbstractQ{Tv}) where {Tv} = SparseMatrixCSC{Tv,Int}(Q)
1002+
sparse(Q::AbstractQ) = SparseMatrixCSC(Q)
10011003

10021004
sparse(T::SymTridiagonal) = SparseMatrixCSC(T)
10031005

0 commit comments

Comments
 (0)