zed: Reduce log noise for large JBODs

behlendorf · defaziogiancarlo · commit 4638eb2bef6a · 2023-07-26T09:39:02.000-07:00
For large JBODs the log message "zfs_iter_vdev: no match" can account for the bulk of the log messages (over 70%). Since this message is purely informational and not that useful we remove it. Reviewed-by: Olaf Faaland <faaland1@llnl.gov> Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#15086 Closes openzfs#15094 Signed-off-by: Gian-Carlo DeFazio <defazio1@llnl.gov> (cherry picked from commit 782312c)
diff --git a/cmd/zed/agents/zfs_mod.c b/cmd/zed/agents/zfs_mod.c
@@ -597,8 +597,6 @@ zfs_iter_vdev(zpool_handle_t *zhp, nvlist_t *nvl, void *data)
 		 */
 		if (nvlist_lookup_string(nvl, dp->dd_prop, &path) != 0 ||
 		    strcmp(dp->dd_compare, path) != 0) {
-			zed_log_msg(LOG_INFO, "  %s: no match (%s != vdev %s)",
-			    __func__, dp->dd_compare, path);
 			return;
 		}
 		if (dp->dd_new_vdev_guid != 0 && dp->dd_new_vdev_guid != guid) {

Original file line number	Diff line number	Diff line change
`@@ -597,8 +597,6 @@ zfs_iter_vdev(zpool_handle_t zhp, nvlist_t nvl, void *data)`
`597`	`597`	`*/`
`598`	`598`	`if (nvlist_lookup_string(nvl, dp->dd_prop, &path) != 0 \|\|`
`599`	`599`	`strcmp(dp->dd_compare, path) != 0) {`
`600`		`- zed_log_msg(LOG_INFO, " %s: no match (%s != vdev %s)",`
`601`		`- __func__, dp->dd_compare, path);`
`602`	`600`	`return;`
`603`	`601`	`}`
`604`	`602`	`if (dp->dd_new_vdev_guid != 0 && dp->dd_new_vdev_guid != guid) {`