fix: make silent global flag instead of only for claims

Author: gpabst

pkg/internal/common/flags/common.go

@@ -14,5 +14,6 @@ func GetSignerFlags() []cli.Flag {
 		&FireblocksTimeoutFlag,
 		&FireblocksSecretStorageTypeFlag,
 		&Web3SignerUrlFlag,
+		&SilentFlag,
 	}
 }

pkg/internal/common/flags/general.go

@@ -75,4 +75,11 @@ var (
 		Usage:   "Enable verbose logging",
 		EnvVars: []string{"VERBOSE"},
 	}
+
+	SilentFlag = cli.BoolFlag{
+		Name:    "silent",
+		Aliases: []string{"s"},
+		Usage:   "Suppress unnecessary output (except for claim data to enable piping)",
+		EnvVars: []string{"SILENT"},
+	}
 )

pkg/internal/common/helper.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"io"
 	"log/slog"
 	"math/big"
 	"os"
@@ -445,6 +446,11 @@ func IsEmptyString(s string) bool {
 
 func GetLogger(cCtx *cli.Context) eigensdkLogger.Logger {
 	verbose := cCtx.Bool(flags.VerboseFlag.Name)
+
+	if cCtx.Bool(flags.SilentFlag.Name) {
+		return eigensdkLogger.NewTextSLogger(io.Discard, nil)
+	}
+
 	loggerOptions := &eigensdkLogger.SLoggerOptions{
 		Level: slog.LevelInfo,
 	}

pkg/rewards/claim.go

@@ -5,7 +5,6 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io"
 	"math/big"
 	"net/http"
 	"sort"
@@ -75,7 +74,6 @@ func getClaimFlags() []cli.Flag {
 		&ClaimTimestampFlag,
 		&ProofStoreBaseURLFlag,
 		&flags.VerboseFlag,
-		&SilentFlag,
 	}
 
 	allFlags := append(baseFlags, flags.GetSignerFlags()...)
@@ -87,10 +85,6 @@ func Claim(cCtx *cli.Context, p utils.Prompter) error {
 	ctx := cCtx.Context
 	logger := common.GetLogger(cCtx)
 
-	if cCtx.Bool(SilentFlag.Name) {
-		logger = logging.NewTextSLogger(io.Discard, nil)
-	}
-
 	config, err := readAndValidateClaimConfig(cCtx, logger)
 	if err != nil {
 		return eigenSdkUtils.WrapError("failed to read and validate claim config", err)
@@ -246,24 +240,31 @@ func Claim(cCtx *cli.Context, p utils.Prompter) error {
 				logger.Infof("Claim written to file: %s", config.Output)
 			} else {
 				fmt.Println(string(jsonData))
-				logger.Info("To write to a file, use the --output flag")
+				fmt.Println()
+				fmt.Println("To write to a file, use the --output flag")
 			}
 		} else {
 			if !common.IsEmptyString(config.Output) {
-				logger.Info("output file not supported for pretty output type")
+				fmt.Println("output file not supported for pretty output type")
+				fmt.Println()
 			}
 			solidityClaim := claimgen.FormatProofForSolidity(accounts.Root(), claim)
-			logger.Info("------- Claim generated -------")
+			if !config.IsSilent {
+				fmt.Println("------- Claim generated -------")
+			}
 			common.PrettyPrintStruct(*solidityClaim)
-			logger.Info("-------------------------------")
-			logger.Info("To write to a file, use the --output flag")
+			if !config.IsSilent {
+				fmt.Println("-------------------------------")
+				fmt.Println("To write to a file, use the --output flag")
+			}
 		}
-		if !cCtx.Bool(SilentFlag.Name) {
+		if !config.IsSilent {
 			txFeeDetails := common.GetTxFeeDetails(unsignedTx)
-			logger.Info("\n")
+			fmt.Println()
 			txFeeDetails.Print()
+
+			fmt.Println("To broadcast the claim, use the --broadcast flag")
 		}
-		logger.Info("To broadcast the claim, use the --broadcast flag")
 	}
 
 	return nil
@@ -372,6 +373,7 @@ func readAndValidateClaimConfig(cCtx *cli.Context, logger logging.Logger) (*Clai
 	splitTokenAddresses := strings.Split(tokenAddresses, ",")
 	validTokenAddresses := getValidHexAddresses(splitTokenAddresses)
 	rewardsCoordinatorAddress := cCtx.String(RewardsCoordinatorAddressFlag.Name)
+	isSilent := cCtx.Bool(SilentFlag.Name)
 
 	var err error
 	if common.IsEmptyString(rewardsCoordinatorAddress) {
@@ -455,6 +457,7 @@ func readAndValidateClaimConfig(cCtx *cli.Context, logger logging.Logger) (*Clai
 		SignerConfig:              signerConfig,
 		ClaimTimestamp:            claimTimestamp,
 		ClaimerAddress:            claimerAddress,
+		IsSilent:                  isSilent,
 	}, nil
 }
 

pkg/rewards/types.go

@@ -30,6 +30,7 @@ type ClaimConfig struct {
 	ProofStoreBaseURL         string
 	Environment               string
 	SignerConfig              *types.SignerConfig
+	IsSilent                  bool
 }
 
 type SetClaimerConfig struct {