Skip to content

Commit 78d067d

Browse files
author
ali-alshaar7
committed
update tests
1 parent 771bb09 commit 78d067d

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

tests/test_readme.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,7 @@ def test_serve():
208208
def run_server():
209209
nonlocal process
210210
try:
211-
process = subprocess.Popen(run_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
212-
stdout, stderr = process.communicate(timeout=60)
211+
process = subprocess.Popen(run_command, text=True)
213212
except subprocess.TimeoutExpired:
214213
print("Server start-up timeout expired")
215214

tests/test_serve.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ def test_simple(tmp_path):
3636
def run_server():
3737
nonlocal process
3838
try:
39-
process = subprocess.Popen(run_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
40-
stdout, stderr = process.communicate(timeout=60)
39+
process = subprocess.Popen(run_command, text=True)
4140
except subprocess.TimeoutExpired:
4241
print("Server start-up timeout expired")
4342

@@ -87,8 +86,7 @@ def test_quantize(tmp_path):
8786
def run_server():
8887
nonlocal process
8988
try:
90-
process = subprocess.Popen(run_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
91-
stdout, stderr = process.communicate(timeout=10)
89+
process = subprocess.Popen(run_command, text=True)
9290
except subprocess.TimeoutExpired:
9391
print("Server start-up timeout expired")
9492

@@ -137,8 +135,7 @@ def test_multi_gpu_serve(tmp_path):
137135
def run_server():
138136
nonlocal process
139137
try:
140-
process = subprocess.Popen(run_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
141-
stdout, stderr = process.communicate(timeout=10)
138+
process = subprocess.Popen(run_command, text=True)
142139
except subprocess.TimeoutExpired:
143140
print("Server start-up timeout expired")
144141

0 commit comments

Comments
 (0)