-
Notifications
You must be signed in to change notification settings - Fork 16
Win-amd64 wheel sets incorrect OpenBLAS_LIBRARIES
in OpenBLASConfig.cmake
#202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
OpenBLAS_LIBRARIES
in OpenBLASConfig.cmake
OpenBLAS_LIBRARIES
in OpenBLASConfig.cmake
Sorry, this was the wrong reference. It's not about the arm64 wheels, but the amd64 wheels. The
In fact, the |
OpenBLAS_LIBRARIES
in OpenBLASConfig.cmake
OpenBLAS_LIBRARIES
in OpenBLASConfig.cmake
If I understand correctly, the last line in SET(OpenBLAS_VERSION "0.3.29.dev")
file(REAL_PATH "../../.." _OpenBLAS_ROOT_DIR BASE_DIRECTORY ${CMAKE_CURRENT_LIST_DIR} )
SET(OpenBLAS_INCLUDE_DIRS ${_OpenBLAS_ROOT_DIR}/include)
-SET(OpenBLAS_LIBRARIES ${_OpenBLAS_ROOT_DIR}/bin/libscipy_openblas.dll)
+SET(OpenBLAS_LIBRARIES ${_OpenBLAS_ROOT_DIR}/lib/libscipy_openblas.lib) and in scipy-openblas64 should be SET(OpenBLAS_VERSION "0.3.29.dev")
file(REAL_PATH "../../.." _OpenBLAS_ROOT_DIR BASE_DIRECTORY ${CMAKE_CURRENT_LIST_DIR} )
SET(OpenBLAS_INCLUDE_DIRS ${_OpenBLAS_ROOT_DIR}/include)
-SET(OpenBLAS_LIBRARIES ${_OpenBLAS_ROOT_DIR}/bin/libscipy_openblas64_.dll)
+SET(OpenBLAS_LIBRARIES ${_OpenBLAS_ROOT_DIR}/lib/libscipy_openblas64_.lib) With that change, can you use CMake in the NumPy/SciPy build? |
I did not attempt building NumPy/SciPy, but another project (https://github.com/AMICI-dev/AMICI/). Nevertheless, with these changes, the CMake configuration of I did not / cannot test |
Will be fixed by a 0.3.265.2 release in a bit. Does posix (linux, macOS) work? |
Uh oh!
There was an error while loading. Please reload this page.
Hi, thanks for creating the OpenBLAS wheels!
I noticed a small issue with the CMake package configuration on Windows:
In the latest PyPI scipy_openblas64 wheel for win_amd64, the library is located at
lib/libscipy_openblas64_.dll
. However,OpenBLASConfig.cmake
expects the library atbin/libscipy_openblas64_.dll
:The library is moved from
bin/
tolib/
here:openblas-libs/.github/workflows/windows.yml
Line 105 in 82e3f04
But the CMake package configuration is just copied without updating the changed library path here:
openblas-libs/tools/build_steps_win_arm64.bat
Line 142 in 82e3f04
EDIT: And
OpenBLAS_LIBRARIES
should actually point to the.lib
file, not the.dll
.The text was updated successfully, but these errors were encountered: