Skip to content

SurroundingRectangle supports *mobjects #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrDiver opened this issue Jul 15, 2024 · 2 comments
Closed

SurroundingRectangle supports *mobjects #3863

MrDiver opened this issue Jul 15, 2024 · 2 comments
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Milestone

Comments

@MrDiver
Copy link
Collaborator

MrDiver commented Jul 15, 2024

Quickfix for SurroundingRectangle to add the functionality to surround multiple objects without creating an extra VGroup

@MrDiver MrDiver added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Jul 15, 2024
@MrDiver MrDiver added this to the v0.19.0 milestone Jul 15, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Jul 15, 2024
@JasonGrace2282 JasonGrace2282 modified the milestones: v0.19.0, v0.20.0 Jul 23, 2024
@Boris-Filin
Copy link
Contributor

Hello there!
We have to do some OSC for uni (I know, I know...), and I would like to take a swing at this fix.
I am thinking that this could be done by creating a temporary VGroup under the hood inside SurroundingRectangle itself.
As for syntaxis, I think it would make most sense to add a classmethod such as "mobjects" that would be separate to the main constructor, while still providing the necessary functionality.

box = SurroundingRectangle.mobjects([quote, title], color=YELLOW, buff=MED_LARGE_BUFF)

Would you mind if I take this issue?
I'd appreciate any notes you have on the above ideas.

@JasonGrace2282
Copy link
Member

Closed by #3964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants