test: Add `e2e` test for `transfer` confirmations #15346

OGPoyraz · 2025-05-15T07:24:46Z

Description

This PR aims to adjust e2e tests and infrastructure.

E2e tests changes:

Adds e2e/specs/confirmations-redesigned/transactions/wallet-initiated-transfer.spec.js
- Basic send flow e2e tests
- Use max e2e test
Adds e2e/specs/confirmations-redesigned/transactions/dapp-initiated-transfer.spec.js
- EIP1559 transfer button in test-dapp
Adds e2e/specs/confirmations-redesigned/transactions/contract-interaction.spec.js
- Basic ERC721 mint interaction
Re-enable skipped security alert API e2e

Infrastructure changes:

Remove section ids as we are using "rows" now
- Rename existing sections into rows.
Add ignoreFields support to mock-server in case if we want to ignore fields from request - this gives us flexibility of mocking requests.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4874
Fixes: #15726

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

app/components/Views/confirmations/components/info/transfer/transfer.tsx

e2e/api-mocking/mock-server.js

e2e/pages/Browser/Confirmations/PageSections.js

github-actions · 2025-06-01T07:06:24Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8188775
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/30d60dfe-b80e-4494-92d6-164a2bc203dd

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-06-04T02:58:32Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: deafb3b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/45e3c96a-c5cb-4758-a5e3-98b38b5107e3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-06-04T04:39:12Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5338f08
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4dccc8dd-b3c3-409c-83b4-601c45c26f37

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-06-04T05:55:01Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: de7c083
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/651abef1-bc71-40c2-a1fa-65ce8a80754f

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

OGPoyraz · 2025-06-04T16:02:13Z

As last commit already passed e2e here : #15346 (comment)
And I fixed conflict just on app/components/Views/confirmations/components/UI/inline-alert/inline-alert.tsx to save some time - I will add "No e2e smoke needed"

sonarqubecloud · 2025-06-04T16:11:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cortisiko

small feedback, your code looks 👨‍🍳

cortisiko · 2025-06-04T16:26:24Z

e2e/pages/Browser/Confirmations/RowComponents.js

@@ -0,0 +1,50 @@
+import { ConfirmationRowComponentIDs } from '../../../selectors/Confirmation/ConfirmationView.selectors';


We are working on migrating from js to ts. Can you convert this file to ts so its one less file we need to worrk about?

cortisiko · 2025-06-04T16:26:32Z

e2e/pages/Browser/Confirmations/ConfirmationUITypes.js

@@ -0,0 +1,14 @@
+import { ConfirmationUIType } from '../../../selectors/Confirmation/ConfirmationView.selectors';


We are working on migrating from js to ts. Can you convert this file to ts so its one less file we need to worrk about?

cortisiko · 2025-06-04T16:26:54Z

e2e/specs/confirmations-redesigned/transactions/contract-interaction.spec.js

@@ -0,0 +1,87 @@
+import { SMART_CONTRACTS } from '../../../../app/util/test/smart-contracts';


Can you convert your new tests to ts instead

OGPoyraz requested a review from a team as a code owner May 15, 2025 07:24

OGPoyraz marked this pull request as draft May 15, 2025 07:24

metamaskbot added the team-confirmations Push issues to confirmations team label May 15, 2025

OGPoyraz commented May 15, 2025

View reviewed changes

app/components/Views/confirmations/components/info/transfer/transfer.tsx Outdated Show resolved Hide resolved

OGPoyraz commented May 15, 2025

View reviewed changes

e2e/api-mocking/mock-server.js Show resolved Hide resolved

OGPoyraz commented May 15, 2025

View reviewed changes

e2e/pages/Browser/Confirmations/PageSections.js Show resolved Hide resolved

OGPoyraz added Run Smoke E2E Requires smoke E2E testing and removed DO-NOT-MERGE Pull requests that should not be merged No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jun 1, 2025

OGPoyraz marked this pull request as ready for review June 1, 2025 07:06

OGPoyraz changed the title ~~[DRAFT] test: Add e2e test for transfer confirmations~~ test: Add e2e test for transfer confirmations Jun 1, 2025

OGPoyraz marked this pull request as draft June 1, 2025 08:00

OGPoyraz force-pushed the ogp/4874 branch from 6219bbb to 0706d88 Compare June 4, 2025 02:50

OGPoyraz marked this pull request as ready for review June 4, 2025 02:50

OGPoyraz added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 4, 2025

OGPoyraz mentioned this pull request Jun 4, 2025

Security Alert API e2e failure #15726

Closed

9 tasks

OGPoyraz linked an issue Jun 4, 2025 that may be closed by this pull request

Security Alert API e2e failure #15726

Closed

9 tasks

OGPoyraz added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 4, 2025

OGPoyraz added 15 commits June 4, 2025 17:55

Update animated pulse testID

3dcf61c

Update e2e tests

99a12eb

Enable the skipped test

1149058

Update tests

2f0f893

Update tests

060ead4

Fix tests

389fb8c

Fix tests

2df7084

Update tests

15487bf

Fix tests

1bffb2d

Fix send max e2e

370b282

Update send max tests

ee03b14

Fix tests

064cf1e

Fix assertion

99631f3

Fix conflict

2b1bcf7

Fix testId

9eea640

OGPoyraz dismissed pedronfigueiredo’s stale review via 9eea640 June 4, 2025 15:56

OGPoyraz force-pushed the ogp/4874 branch from da63abb to 9eea640 Compare June 4, 2025 15:56

pedronfigueiredo approved these changes Jun 4, 2025

View reviewed changes

OGPoyraz removed the Run Smoke E2E Requires smoke E2E testing label Jun 4, 2025

OGPoyraz added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Jun 4, 2025

OGPoyraz enabled auto-merge June 4, 2025 16:02

OGPoyraz added this pull request to the merge queue Jun 4, 2025

cortisiko requested changes Jun 4, 2025

View reviewed changes

Merged via the queue into main with commit cf783d1 Jun 4, 2025
47 of 48 checks passed

OGPoyraz deleted the ogp/4874 branch June 4, 2025 16:36

github-actions bot locked and limited conversation to collaborators Jun 4, 2025

metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label Jun 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test: Add `e2e` test for `transfer` confirmations #15346

test: Add `e2e` test for `transfer` confirmations #15346

OGPoyraz commented May 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 1, 2025 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Jun 4, 2025 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Jun 4, 2025 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

OGPoyraz commented Jun 4, 2025

Uh oh!

sonarqubecloud bot commented Jun 4, 2025

Uh oh!

cortisiko left a comment

Uh oh!

cortisiko Jun 4, 2025

Uh oh!

cortisiko Jun 4, 2025

Uh oh!

cortisiko Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -0,0 +1,50 @@
		import { ConfirmationRowComponentIDs } from '../../../selectors/Confirmation/ConfirmationView.selectors';

		@@ -0,0 +1,14 @@
		import { ConfirmationUIType } from '../../../selectors/Confirmation/ConfirmationView.selectors';

		@@ -0,0 +1,87 @@
		import { SMART_CONTRACTS } from '../../../../app/util/test/smart-contracts';

Uh oh!

test: Add e2e test for transfer confirmations #15346

test: Add e2e test for transfer confirmations #15346

Conversation

OGPoyraz commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 1, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Jun 4, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Jun 4, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Jun 4, 2025

Bitrise

Uh oh!

OGPoyraz commented Jun 4, 2025

Uh oh!

sonarqubecloud bot commented Jun 4, 2025

Quality Gate passed

Uh oh!

cortisiko left a comment

Choose a reason for hiding this comment

Uh oh!

cortisiko Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

cortisiko Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

cortisiko Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

test: Add `e2e` test for `transfer` confirmations #15346

test: Add `e2e` test for `transfer` confirmations #15346

OGPoyraz commented May 15, 2025 •

edited

Loading

github-actions bot commented Jun 1, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jun 4, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jun 4, 2025 •

edited by metamaskbot

Loading