Merge pull request #101 from ModelOriented/package_version

Package version fix

Author: mayer79

CRAN-SUBMISSION

@@ -1,3 +1,3 @@
-Version: 0.9.0
-Date: 2023-06-09 14:22:29 UTC
-SHA: 3f6bd1f781851c169a080adb317142b133f58147
+Version: 0.9.1
+Date: 2023-07-18 17:24:12 UTC
+SHA: 447cbcf8fca1601079604e015c68fb52171ae2ab

NEWS.md

@@ -4,6 +4,10 @@
 
 - `dimnames.shapviz()` has received a replacement method. You can thus change the column names of SHAP matrix and feature data (as well as SHAP interactions) by `colnames(x) <- ...`, see https://github.com/ModelOriented/shapviz/issues/98
 
+## Maintenance
+
+- Fix for https://github.com/ModelOriented/shapviz/issues/100 (`package_version()` applied to numeric value will be deprecated in the future)
+
 # shapviz 0.9.0
 
 ## New features

R/shapviz.R

@@ -251,7 +251,7 @@ shapviz.lgb.Booster = function(object, X_pred, X = X_pred,
   )
 
   # Switch for different versions of predict.lgb.Booster()
-  is_v4 <- utils::packageVersion("lightgbm") >= 4
+  is_v4 <- utils::packageVersion("lightgbm") >= "4"
   has_type <- "type" %in% names(formals(utils::getS3method("predict", "lgb.Booster")))
   if (is_v4 || has_type) {
     S <- stats::predict(object, newdata = X_pred, type = "contrib", ...)

cran-comments.md

@@ -1,43 +1,27 @@
-# Re-resubmission
-
-Examples that take 0.09 seconds on my Windows laptop take 6 seconds on Linux. I don't know how to fix this, so I am resorting to dontruns around all examples involving XGBoost.
-
-# Re-resubmission
-
-Examples still taking too long on Linux. No idea how to fix this except using dontruns...
-
-# Resubmission
-
-Examples taking too long on Linux. 
-
-- I have now reduced the number of examples.
-- And the number of boosting rounds.
-
-# shapviz 0.9.0
+# shapviz 0.9.1
 
 Hello CRAN team
 
-- I have added a beautiful house price dataset with 14000 transactions from Miami in 2016. A friend of mine has created it (Prof. Steven Bourassa).
-- There is a new plot `sv_dependence2D()` that is ideal for visualization of geographic components.
-- Added new vignette on SHAP analyses for models with geographic components.
+This is a small release fixing a future problem pointed out by Kurt Hornik about applying package_version() to numeric input.
 
 ## Checks look good
 
 ### check(manual = TRUE, cran = TRUE)
 
-> checking HTML version of manual ... NOTE
+- checking for future file timestamps ... NOTE
+  unable to verify current time
+  
+- checking HTML version of manual ... NOTE
   Skipping checking HTML validation: no command 'tidy' found
 
 ### RHub
 
-* checking package dependencies ... NOTE
-Packages which this enhances but not available for checking:
-  'fastshap', 'h2o', 'lightgbm'
-* checking HTML version of manual ... NOTE
-Skipping checking HTML validation: no command 'tidy' found
-Skipping checking math rendering: package 'V8' unavailable
+debian ok
 
+Others: hanging
 
 ### Winbuilder()
 
 Status: OK
+R Under development (unstable) (2023-07-17 r84702 ucrt)
+